fix(embeded): Don't pollute the scripts dir with target/ by epage · Pull Request #12282 · rust-lang/cargo (original) (raw)

What does this PR try to resolve?

This PR is part of #12207.

This specific behavior was broken in #12268 when we stopped using an intermediate
Cargo.toml file.

Unlike pre-#12268,

• We are hashing the path, rather than the content, with the assumption
  that people change content more frequently than the path
• We are using a simpler hash than blake3 in the hopes that we can get
  away with it

Unlike the Pre-RFC demo

• We are not forcing a single target dir for all scripts in the hopes
  that we get Per-user compiled artifact cache #5931

How should we test and review this PR?

A new test was added specifically to show the target dir behavior, rather than overloading an existing test or making all tests sensitive to changes in this behavior.

Additional information

In the future, we might want to resolve symlinks before we get to this point