fix(embedded): Don't auto-discover build.rs files by epage · Pull Request #12283 · rust-lang/cargo (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation9 Commits2 Checks0 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
With #12268, we moved the manifest root to be the scripts parent
directory, making it so auto-discovery might pick some things up.
We previously ensured auto* don't pick things up but missed build.rs
This is now addressed.
With rust-lang#12268, we moved the manifest root to be the scripts parent directory, making it so auto-discovery might pick some things up.
We previously ensured auto* don't pick things up but missed build.rs
This is now addressed.
r? @ehuss
(rustbot has picked a reviewer for you, use r? to override)
39 tasks
Thanks for the extremely quick fix!!
@bors r+
📌 Commit f8325ac has been approved by weihanglo
It is now in the queue for this repository.
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
bors added a commit that referenced this pull request
fix(embedded): Don't auto-discover build.rs files
With #12268, we moved the manifest root to be the scripts parent directory, making it so auto-discovery might pick some things up.
We previously ensured auto* don't pick things up but missed build.rs
This is now addressed.
Of course the one time I don't run more tests, I get a failure...
Also my fault. I hadn't thought of that.
Feel free to r=weihanglo if there are more tests need to be fixed 🤪.
@bors r+
📌 Commit 3f93030 has been approved by weihanglo
It is now in the queue for this repository.
bors added a commit to rust-lang-ci/rust that referenced this pull request
Labels
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.