Phase 1 of stdlib dependencies (RFC #1133) by Ericson2314 · Pull Request #2768 · rust-lang/cargo (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation18 Commits12 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

This is the first implementation as specified by the RFC. It should contain:

compiler sysroot
explicit stdlib deps, with proper restrictions on their use
implicit stdlib deps
temp workaround keep-stdlib-dependencies key
temp workaround custom-implicit-stdlib-dependencies key

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

Ok, routed some config items for actually using this thing. Still need to write tests on the actual functionality, not just parsing----or test manually though if I can do the former I rather not bother. But, if it works, it's pretty close to done beyond bike-shedding config key names, etc.

matklad

Some(reference) => {
let config = try!(config.get_string("stdlib-repo"));
let url = config.as_ref().map(\|s
.unwrap_or("http://github.com/rust-lang/rust.git");

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is slow (though it's a lot faster when I use the git cli to download myself). What is this manifest though? I don't use rustup.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, I thought that this manifest specifies the things uploaded to https://static.rust-lang.org, but looks like rust sources are already there. Perhaps downloading .tar.gz from static.rust-lang.org would be faster? Or is it significantly more code to write?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the actual URL? (I hate how hard it is to browse https://static.rust-lang.org.) If the nightly repos are up by date, but rustc -vV only gives us the commit hash (both those statements might be false :)), this will be a lot harder.

I'm generally interested in fixing the perf problem with Cargo, but at this point I just want to see explicit stdlib deps in some form and am not too picky :).

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the url should be https://static.rust-lang.org/dist/$date/rustc-nightly-src.tar.gz. rustc -vV includes date:

rustc 1.9.0 (e4e8b6668 2016-05-18)Not sure about beta though. 

binary: rustc
commit-hash: e4e8b666850a763fdf1c3c2c142856ab51e32779
commit-date: 2016-05-18
host: x86_64-unknown-linux-gnu
release: 1.9.0

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh that's good!

☔ The latest upstream changes (presumably #2680) made this pull request unmergeable. Please resolve the merge conflicts.

Ericson2314 changed the title~~[WIP] Implement stdlib dependencies (RFC #1133)~~ [WIP] Phase 1 of stdlib dependencies (RFC #1133)

Ericson2314 changed the title~~[WIP] Phase 1 of stdlib dependencies (RFC #1133)~~ Phase 1 of stdlib dependencies (RFC #1133)

☔ The latest upstream changes (presumably #3064) made this pull request unmergeable. Please resolve the merge conflicts.

(Because I have less time with work, I've enabled maintainer access to this branch.)

The location of the compiler source can be overwritten, but ca

☔ The latest upstream changes (presumably #3175) made this pull request unmergeable. Please resolve the merge conflicts.

@alexcrichton Since you're the assignee here do you have any feedback on this PR? If it looks like this approach will work going forward I'll gladly take it over and get it landed since @Ericson2314 is unable to work on it further.

@cardoe yeah I haven't abandoned this or the RFC, but have been waiting for the RFC to arrive at the front of the queue.

I'm going to close this due to inactivity, in favor of the open RFC.