Add visionOS support by madsmtm · Pull Request #1029 · rust-lang/cc-rs (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation6 Commits5 Checks23 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

We were definitely working on the same thing; I made almost the same changes. The only differences are the XROS_DEPLOYMENT_TARGET and this additional check on lines 2658 and 2674

            // there is no -m{}os-version-min for watchos, tvos, visionos
            if matches!(os, AppleOs::Ios | AppleOs::MacOs) {
                cmd.args.push(
                    format!("-m{}os-version-min={}", sdk_details.sdk_prefix, min_version)
                        .into(),
                );
            }

Add visionOS support by madsmtm · Pull Request #1029 · rust-lang/cc-rs (original) (raw)

Conversation

Choose a reason for hiding this comment