Fix for different hashes between different build paths by harishsadineni1 · Pull Request #1277 · rust-lang/cc-rs (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation2 Commits1 Checks27 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
when the build paths are diffrent for rust sources, the objects files genarted are having diffrent hash values for each build.
- Updated the hashing mechanism to ensure consistent hash values across different build paths.
- Addressed issues with reproducibility by normalizing directory paths before hashing, preventing discrepancies caused by varying build environments.
when the build paths are diffrent for rust sources, the objects files genarted are having diffrent hash values for each build.
- Updated the hashing mechanism to ensure consistent hash values across different build paths.
- Addressed issues with reproducibility by normalizing directory paths before hashing, preventing discrepancies caused by varying build environments.
Signed-off-by: Harish Sadineni Harish.Sadineni@windriver.com
| pos |
|---|
| } |
| let filtered_dirname = if let Some(pos) = find_target_position(&dirname, &target_substring) { |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMHO stripping rustc isn't very reliable, user could have rustc somewhere in the path.
I think stripping CARGO_MANIFEST_DIR is a better solution.
Thanks, I think #1270 already implements this
Fix for diffrent hashes between diffrent build paths Fix for different hashes between different build paths