Make user-specified cflags take precedence over cc-rs flags by madsmtm · Pull Request #232 · rust-lang/cmake-rs (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation4 Commits1 Checks27 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

When the user uses .cflag/.cxxflag/.asmflag, we want those flags to take precedence over the default flags that cc-rs adds.

for posterity, the full error was

   Compiling test-crate v0.1.0 (/Users/runner/work/cmake-rs/cmake-rs/test-crate)
error: linker stderr: ld: search path '/Users/runner/work/cmake-rs/cmake-rs/test-crate/target/debug/build/libz-sys-ae8c893dbe111c55/out/lib64' not found
       ld: object file (/Users/runner/work/cmake-rs/cmake-rs/test-crate/target/debug/deps/liblibz_sys-297f35bb33641431.rlib[31](zutil.c.o)) was built for newer 'macOS' version (14.5) than being linked (11.0)
  |
  = note: `-D linker-messages` implied by `-D warnings`
  = help: to override `-D warnings` add `#[allow(linker_messages)]`

(CI logs go away after about 3 months)

note that i do not plan to silence the "search path" not found error, so that will eventually come back unless someone makes a convincing case why it shouldn't.

2 participants