build.rs: always use freebsd12 when rustc_dep_of_std is set by RalfJung · Pull Request #3723 · rust-lang/libc (original) (raw)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just realized the previous logic for rustc_dep_of_std here wasn't what I thought it was...

The logic was: if the auto-detected version is 12 and rustc_dep_of_std is set, then use freebsd12. If the auto-detected version is anything else and rustc_dep_of_std is set, use freebsd11. If this was deliberate, I don't understand why, and it doesn't match the comments.

With my PR, the logic now is: if rustc_dep_of_std is set, don't even auto-detect, just use version 12. This matches what the comments already said before.