New Lint: Unsafe block in safe functions without SAFETY comment · Issue #7238 · rust-lang/rust-clippy (original) (raw)

Skip to content

Navigation Menu

• • GitHub Copilot Write better code with AI
  • GitHub Advanced Security Find and fix vulnerabilities
  • Actions Automate any workflow
  • Codespaces Instant dev environments
  • Issues Plan and track work
  • Code Review Manage code changes
  • Discussions Collaborate outside of code
  • Code Search Find more, search less
• Explore
  • Learning Pathways
  • Events & Webinars
  • Ebooks & Whitepapers
  • Customer Stories
  • Partners
  • Executive Insights
• • GitHub Sponsors Fund open source developers
  • The ReadME Project GitHub community articles
• • Enterprise platform AI-powered developer platform
• Pricing

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Description

What it does

Detects unsafe blocks used in safe functions missing a comment explaining/justifying the use of unsafe.

Categories (optional)

• Kind: clippy::pedantic

What is the advantage of the recommended code over the original code

• Explains why the use of unsafe in the function is okay
• Makes it easier to maintain

Drawbacks

None.

Example

fn get(self, slice: &[T]) -> Option { if self < slice.len() { unsafe { Some(&*self.get_unchecked(slice)) } } else { None } }

Could be written as:

fn get(self, slice: &[T]) -> Option { // SAFETY: self is checked to be in bounds. if self < slice.len() { unsafe { Some(&*self.get_unchecked(slice)) } } else { None } }