new_ret_no_self false positive when returning impl Trait<Self> · Issue #7344 · rust-lang/rust-clippy (original) (raw)

Skip to content

Navigation Menu

• • GitHub Copilot Write better code with AI
  • GitHub Advanced Security Find and fix vulnerabilities
  • Actions Automate any workflow
  • Codespaces Instant dev environments
  • Issues Plan and track work
  • Code Review Manage code changes
  • Discussions Collaborate outside of code
  • Code Search Find more, search less
• Explore
  • Learning Pathways
  • Events & Webinars
  • Ebooks & Whitepapers
  • Customer Stories
  • Partners
  • Executive Insights
• • GitHub Sponsors Fund open source developers
  • The ReadME Project GitHub community articles
• • Enterprise platform AI-powered developer platform
• Pricing

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Description

Lint name: new_ret_no_self

pub struct Foo;

impl Foo { pub fn new() -> impl Into { Foo } }

causes a warning where it shouldn't. impl Into here can be any trait that has Self in generic arguments.

This is similar to #4359 but instead of Future<Output = Self> it's Into<Self>. #4365's title implies that this should be allowed but actually it only deals with associated types, not type parameters.

cargo clippy -V: 0.1.54 (2021-06-09 eab201d)