[macro_metavars_in_unsafe]: recognize metavariables in tail expressions by y21 · Pull Request #13220 · rust-lang/rust-clippy (original) (raw)

Fixes #13219

macro_metavars_in_unsafe keeps track of the current "expansion depth" (incremented/decremented when entering/leaving a macro span) to tell if an expression from the root context is contained within a macro (see the doc comment I added for a hopefully better explanation)

Before this PR, we didn't increment said expn_depth for unsafe blocks within macros, because we already do that in visit_stmt anyway, so it would work fine for statements, but that's not enough for tail expressions of an unsafe block.

So we now also increment it for macro unsafe blocks.
Also updated the comment for expn_depth while I'm at it because "This is not necessary for correctness" isn't correct now that I think about it

changelog: none