Use diagnostic items where possible by xFrednet · Pull Request #7466 · rust-lang/rust-clippy (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation5 Commits4 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

xFrednet

Clippy still uses a bunch of paths in places that could easily use already defined diagnostic items. This PR updates all references to such paths and also removes a bunch of them that are no longer needed after this cleanup.

Some paths are also used to construct new paths and can therefore not be removed that easily. I've added a doc comment to those instances that recommends the use of the diagnostic item where possible.

And that's it, cleaning crew signing off 🧹 🗑️


changelog: none

(only internal improvements)

cc: #5393

@xFrednet

…ap, HashSet, Borrow, Default`

@xFrednet

@xFrednet

@rust-highfive

r? @flip1995

(rust-highfive has picked a reviewer for you, use r? to override)

@xFrednet

This was referenced

Jul 14, 2021

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request

Jul 16, 2021

@GuillaumeGomez

JohnTitor added a commit to JohnTitor/rust that referenced this pull request

Jul 18, 2021

@JohnTitor

@flip1995

@bors r+

Thanks! (For some reason I totally missed that this PR was opened)

@bors

📌 Commit ecf85f4 has been approved by flip1995

@bors

@bors

@xFrednet xFrednet deleted the 5393-use-more-diagnostic-items branch

July 28, 2021 16:41

eggyal pushed a commit to eggyal/copse that referenced this pull request

Jan 9, 2023

@JohnTitor

@ojeda ojeda mentioned this pull request

Aug 8, 2023