rustc_target: rehome target_abi comment · rust-lang/rust@cd47df7 (original) (raw)
File tree
1 file changed
lines changed
- compiler/rustc_target/src/spec/base/apple
1 file changed
lines changed
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -102,6 +102,12 @@ impl TargetEnv { | ||
| 102 | 102 | } |
| 103 | 103 | } |
| 104 | 104 | |
| 105 | +// NOTE: We originally set `cfg(target_abi = "macabi")` / `cfg(target_abi = "sim")`, | |
| 106 | +// before it was discovered that those are actually environments: | |
| 107 | +// https://github.com/rust-lang/rust/issues/133331 | |
| 108 | +// | |
| 109 | +// But let's continue setting them for backwards compatibility. | |
| 110 | +// FIXME(madsmtm): Warn about using these in the future. | |
| 105 | 111 | fn target_abi(self) -> Abi { |
| 106 | 112 | match self { |
| 107 | 113 | Self::Normal => Abi::Unspecified, |
| @@ -124,12 +130,6 @@ pub(crate) fn base( | ||
| 124 | 130 | llvm_floatabi: Some(FloatAbi::Hard), |
| 125 | 131 | os, |
| 126 | 132 | env: env.target_env(), |
| 127 | -// NOTE: We originally set `cfg(target_abi = "macabi")` / `cfg(target_abi = "sim")`, | |
| 128 | -// before it was discovered that those are actually environments: | |
| 129 | -// https://github.com/rust-lang/rust/issues/133331 | |
| 130 | -// | |
| 131 | -// But let's continue setting them for backwards compatibility. | |
| 132 | -// FIXME(madsmtm): Warn about using these in the future. | |
| 133 | 133 | abi: env.target_abi(), |
| 134 | 134 | cpu: arch.target_cpu(env).into(), |
| 135 | 135 | link_env_remove, |