compiletest: add a proper supports-crate-type: xxx directive · Issue #132309 · rust-lang/rust (original) (raw)

Skip to content

Navigation Menu

• • GitHub Copilot Write better code with AI
  • GitHub Advanced Security Find and fix vulnerabilities
  • Actions Automate any workflow
  • Codespaces Instant dev environments
  • Issues Plan and track work
  • Code Review Manage code changes
  • Discussions Collaborate outside of code
  • Code Search Find more, search less
• Explore
  • Learning Pathways
  • Events & Webinars
  • Ebooks & Whitepapers
  • Customer Stories
  • Partners
  • Executive Insights
• • GitHub Sponsors Fund open source developers
  • The ReadME Project GitHub community articles
• • Enterprise platform AI-powered developer platform
• Pricing

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Description

Apparently needs-dynamic-linking is not equivalent to checking if dylib or cdylib crate types are supported.

• In compiletest, needs-dynamic-linking performs a check based on target cfg's dynamic_linking field + --print=cfg --target $TARGET.
• However, target cfg has an additional field only_cdylib which, if dynamic_linking is true, indicates that only cdylib crate type is supported and not dylib.

  /// Whether dynamic linking is available on this target. Defaults to false.
  pub dynamic_linking: bool,
  /// Whether dynamic linking can export TLS globals. Defaults to true.
  pub dll_tls_export: bool,
  /// If dynamic linking is available, whether only cdylibs are supported.
  pub only_cdylib: bool,

  • This is the case for wasm base, dynamic linking is supported but not dylib crate type, only cdylib is supported.

    // we allow dynamic linking, but only cdylibs. Basically we allow a
    // final library artifact that exports some symbols (a wasm module) but
    // we don't allow intermediate `dylib` crate types
    dynamic_linking: true,
    only_cdylib: true,

Originally posted by @jieyouxu in #130860 (comment)