(re-)Fix private-in-public for RPITIT (original) (raw)

#143357 fixed a latent bug where we weren't detecting private-in-public errors for RPITITs. In order to not break any existing code, @cjgillot temporarily reenabled the previous behavior in #144098.

This issue tracks the crater run to determine if that change had any real-world fallout. Ideally we fix the fallout and re-enable the intended behavior, which is to actually detect private-in-public errors in RPITITs just like RPITs and normal associated items. I'm opening an issue just to make sure the crater run doesn't get forgotten on a closed PR. I probably should've started the crater run here, but oh well! :^)

cc @cjgillot @petrochenkov

You can check out the queue and this experiment's details.

Originally posted by @craterbot in #144098 (comment)