NLL: need 3rd round of review comparing .stderr and .nll.stderr output · Issue #54528 · rust-lang/rust (original) (raw)

Skip to content

Navigation Menu

• • GitHub Copilot Write better code with AI
  • GitHub Advanced Security Find and fix vulnerabilities
  • Actions Automate any workflow
  • Codespaces Instant dev environments
  • Issues Plan and track work
  • Code Review Manage code changes
  • Discussions Collaborate outside of code
  • Code Search Find more, search less
• Explore
  • Learning Pathways
  • Events & Webinars
  • Ebooks & Whitepapers
  • Customer Stories
  • Partners
  • Executive Insights
• • GitHub Sponsors Fund open source developers
  • The ReadME Project GitHub community articles
• • Enterprise platform AI-powered developer platform
• Pricing

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Description

NLL keeps getting better and better. But so does our test suite (or at least the percentage of our test suite that is exercising --compare-mode=nll)!

So once again, we need to do another round of review of the differences between AST borrowck diagnostic output and NLL borrowck diagnostic output.

• see NLL: must review all .nll.stderr files #49862 and NLL: need a (new) round of review of deltas between .stderr and .nll.stderr output #52663 for the previous rounds of review

Review started with the .nll.stderr files in the repository as of commit f99911a Tue Oct 23 17:44:19 2018 +0000

though I am actually going to review the state of these files that results from merging in PR #55221

Each file is mapped to a "card" on the project: https://github.com/rust-lang/rust/projects/10

You can use the search function to find a card (though note that most of the cards use a path like ui/vec/vec-mut-iter-borrow.nll.stderr and the search bar look for text within a token. So you need to type the path starting from ui/... into the search bar. I may go through and add spaces in the paths to counteract this.)