Change implementation of -Z gcc-ld and lld-wrapper again by petrochenkov · Pull Request #100200 · rust-lang/rust (original) (raw)

A test to ensure that -Zgcc-ld=lld works on osx now and in the future would have been good to have (especially with an eye towards the rust-lld MCP) so I've been trying to reproduce the initial issue, without success unfortunately.

I'm not sure which version of clang (or macos) was used and when/why it starts switching to response files instead of CLI args. Even with many long link args (the CLI was 23K chars), it still seems to work on an M1 on Monterey (maybe this only happens on x64 darwin but it seems doubtful).

This PR looks good to me as well, but I'd like to make sure: @tschuett, does the thumbs up you left on the OP mean that you were able to test this PR on the project triggering #97755 successfully ? Would you have a repository where we could reproduce the issue by any chance ?

I'd like to have an answer and hopefully I can reduce a test out of that, before merging this PR.

But if it's not possible, and @tschuett has indeed validated the fix, r=me (+mark).