rustdoc: remove .impl-items { flex-basis } CSS, not in flex container by notriddle · Pull Request #101349 · rust-lang/rust (original) (raw)

Added in 34bd2b8

For this to actually do anything, according to MDN (and Firefox Dev Tools), it must be a "flex item", which only happens if its a direct child of a node with display: flex on it. It seems like it could not have worked at the time when this rule was added, because the only items in rustdoc.css with display: flex active were:

• #help

  This should not contain anything like this.

• .impl-items h4, h4.impl, h3.impl

  These are all headers, so they shouldn't contain .impl-items either.

• .content .impl-items .method, .content .impl-items > .type, .impl-items > .associatedconstant

  Associated constants and methods definitely shouldn't contain a list of impl items, and the .type class seems to refer to type aliases, which, when shown inside of an impl, only show a link to the aliased type.

Nowadays, display: flex is a lot more prolific, but .impl-items still seems to only be used in plain block parents:

• If it's not a trait impl, then it's nested below a <div> with an id but no class, added in a5216cf. This will be display: block, probably. For example, vec deref
• Inherent impls also get a <div> tag, for example vec impl, and they are also wrapped by their own non-flexbox <details> tag.
• If it's a tait implementation, then it's also nested below a <details> container, like deref cstring.

Also, this would imply that trait items ought to take up as much space as possible, pushing everything else to the edge of the screen. If this is nested directly below the .rustdoc container, which has a row basis, that would be bad.