nicer errors from assert_unsafe_precondition by RalfJung · Pull Request #102732 · rust-lang/rust (original) (raw)
Finished benchmarking commit (538f118): comparison URL.
Overall result: ❌ regressions - ACTION NEEDED
Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please open an issue or create a new PR that fixes the regressions, add a comment linking to the newly created issue or PR, and then add the perf-regression-triaged label to this PR.
@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance
Instruction count
This is a highly reliable metric that was used to determine the overall result at the top of this comment.
| mean1 | range | count2 | |
|---|---|---|---|
| Regressions ❌ (primary) | 0.8% | [0.6%, 0.9%] | 6 |
| Regressions ❌ (secondary) | - | - | 0 |
| Improvements ✅ (primary) | - | - | 0 |
| Improvements ✅ (secondary) | - | - | 0 |
| All ❌✅ (primary) | 0.8% | [0.6%, 0.9%] | 6 |
Max RSS (memory usage)
Results
This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
| mean1 | range | count2 | |
|---|---|---|---|
| Regressions ❌ (primary) | 2.9% | [2.2%, 3.3%] | 4 |
| Regressions ❌ (secondary) | 2.7% | [1.3%, 4.0%] | 59 |
| Improvements ✅ (primary) | - | - | 0 |
| Improvements ✅ (secondary) | - | - | 0 |
| All ❌✅ (primary) | 2.9% | [2.2%, 3.3%] | 4 |
Cycles
Results
This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
| mean1 | range | count2 | |
|---|---|---|---|
| Regressions ❌ (primary) | 2.8% | [2.8%, 2.8%] | 1 |
| Regressions ❌ (secondary) | - | - | 0 |
| Improvements ✅ (primary) | -1.9% | [-1.9%, -1.9%] | 1 |
| Improvements ✅ (secondary) | -2.1% | [-2.1%, -2.1%] | 1 |
| All ❌✅ (primary) | 0.5% | [-1.9%, 2.8%] | 2 |