Check AArch64 branch-protection earlier in the pipeline. by jacobbramley · Pull Request #105421 · rust-lang/rust (original) (raw)

💔 Test failed - checks-actions

The test fails on an off-by-one error on some documentation layout. It doesn't appear at all relevant to this PR. Note, however, that I can reproduce the error reliably on my branch, but only when run as part of the full sequence. For example, I can't reproduce it by isolating the failing test as follows:

x test --stage 2 src/test/rustdoc-gui --test-args '--no-sandbox --jobs 1 --file scrape-examples-button-focus.goml'

Note that dropping --jobs 1 gets me different results, with intermittent failures on varying tests. However, the tests don't run that way in CI so that usage might not be expected to work anyway.

Attempting to work out what the failure actually was:

[Expected 248 for property scrollTop, found 249]

Manually rendering the test file in Firefox shows a scrollTop of 249 (before and after the navigation operation), so I suspect that the initialScrollTop seen in the test is the anomaly (or perhaps this is just browser variation).

At this point, I am somewhat at a loss. @willcrichton, it seems that you did some work on this test recently. Have you any ideas?