Implement some candidates for the new solver (redux) by compiler-errors · Pull Request #107004 · rust-lang/rust (original) (raw)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would it make sense to take the

probe { instantiate_constituent_tys_for_X evaluate_goal_for_constituent_tys_and_make_canonical_response }

pattern and make that a function taking a closure/function for instantiate_constituent_tys_for_X, removing the separate function for
evaluate_goal_for_constituent_tys_and_make_canonical_response?

I think it would also be nice to maybe move all impls of instantiate_constituent_tys_for_X into a submodule as their concrete impl is fairly unimportant when trying to understand the solver.

Apart from these nits r=me 👍