Allow impl on projection by GuillaumeGomez · Pull Request #107263 · rust-lang/rust (original) (raw)

However, a bug appeared from the privacy check as the CI will show: it has some false positive with "private type in public interface". Not sure why though. The backtrace for it is here:

  12:     0x7fef586494c5 - <rustc_privacy[dc2692dda3b059d]::SearchInterfaceForPrivateItemsVisitor as rustc_privacy[dc2692dda3b059d]::DefIdVisitor>::visit_def_id
  13:     0x7fef5863f6ff - <rustc_privacy[dc2692dda3b059d]::DefIdVisitorSkeleton<rustc_privacy[dc2692dda3b059d]::SearchInterfaceForPrivateItemsVisitor> as rustc_middle[2d95345cc9d1265e]::ty::visit::TypeVisitor>::visit_ty
  14:     0x7fef5863f9d2 - <rustc_privacy[dc2692dda3b059d]::DefIdVisitorSkeleton<rustc_privacy[dc2692dda3b059d]::SearchInterfaceForPrivateItemsVisitor> as rustc_middle[2d95345cc9d1265e]::ty::visit::TypeVisitor>::visit_ty
  15:     0x7fef586484c2 - <rustc_privacy[dc2692dda3b059d]::SearchInterfaceForPrivateItemsVisitor>::ty
  16:     0x7fef586497c5 - <rustc_privacy[dc2692dda3b059d]::PrivateItemsInPublicInterfacesChecker>::check_assoc_item
  17:     0x7fef5864bba5 - rustc_privacy[dc2692dda3b059d]::check_private_in_public
  18:     0x7fef59c15a66 - rustc_query_system[a3c6a6fb37b6854f]::query::plumbing::try_execute_query::<rustc_query_impl[eee68f6de69b6b9]::queries::check_private_in_public, rustc_query_impl[eee68f6de69b6b9]::plumbing::QueryCtxt>
  19:     0x7fef598fc292 - <rustc_query_impl[eee68f6de69b6b9]::Queries as rustc_middle[2d95345cc9d1265e]::ty::query::QueryEngine>::check_private_in_public
  20:     0x7fef58179756 - <core[3d15cbc1632fd665]::panic::unwind_safe::AssertUnwindSafe<rustc_interface[2af05e4c67454c01]::passes::analysis::{closure#5}::{closure#1}> as core[3d15cbc1632fd665]::ops::function::FnOnce<()>>::call_once
  21:     0x7fef580e26c5 - <rustc_session[da714fc9e163a7bd]::session::Session>::time::<(), rustc_interface[2af05e4c67454c01]::passes::analysis::{closure#5}>
  22:     0x7fef580b9dac - rustc_interface[2af05e4c67454c01]::passes::analysis
  23:     0x7fef59c644b2 - rustc_query_system[a3c6a6fb37b6854f]::query::plumbing::try_execute_query::<rustc_query_impl[eee68f6de69b6b9]::queries::analysis, rustc_query_impl[eee68f6de69b6b9]::plumbing::QueryCtxt>
  24:     0x7fef598cfb95 - <rustc_query_impl[eee68f6de69b6b9]::Queries as rustc_middle[2d95345cc9d1265e]::ty::query::QueryEngine>::analysis
  25:     0x7fef57f91c03 - <rustc_interface[2af05e4c67454c01]::passes::QueryContext>::enter::<rustc_driver[de5d577c9fbc1a01]::run_compiler::{closure#1}::{closure#2}::{closure#2}, core[3d15cbc1632fd665]::result::Result<(), rustc_errors[c6c462034af138b3]::ErrorGuaranteed>>
  26:     0x7fef57f7383a - <rustc_interface[2af05e4c67454c01]::queries::QueryResult<rustc_interface[2af05e4c67454c01]::passes::QueryContext>>::enter::<core[3d15cbc1632fd665]::result::Result<(), rustc_errors[c6c462034af138b3]::ErrorGuaranteed>, rustc_driver[de5d577c9fbc1a01]::run_compiler::{closure#1}::{closure#2}::{closure#2}>
  27:     0x7fef57fddc76 - <rustc_interface[2af05e4c67454c01]::interface::Compiler>::enter::<rustc_driver[de5d577c9fbc1a01]::run_compiler::{closure#1}::{closure#2}, core[3d15cbc1632fd665]::result::Result<core[3d15cbc1632fd665]::option::Option<rustc_interface[2af05e4c67454c01]::queries::Linker>, rustc_errors[c6c462034af138b3]::ErrorGuaranteed>>
  28:     0x7fef5800406a - rustc_span[29a73c65a118f2f3]::with_source_map::<core[3d15cbc1632fd665]::result::Result<(), rustc_errors[c6c462034af138b3]::ErrorGuaranteed>, rustc_interface[2af05e4c67454c01]::interface::run_compiler<core[3d15cbc1632fd665]::result::Result<(), rustc_errors[c6c462034af138b3]::ErrorGuaranteed>, rustc_driver[de5d577c9fbc1a01]::run_compiler::{closure#1}>::{closure#0}::{closure#0}>
  29:     0x7fef57fd44c5 - <scoped_tls[535ca24a62cbd8c4]::ScopedKey<rustc_span[29a73c65a118f2f3]::SessionGlobals>>:📐:<rustc_interface[2af05e4c67454c01]::interface::run_compiler<core[3d15cbc1632fd665]::result::Result<(), rustc_errors[c6c462034af138b3]::ErrorGuaranteed>, rustc_driver[de5d577c9fbc1a01]::run_compiler::{closure#1}>::{closure#0}, core[3d15cbc1632fd665]::result::Result<(), rustc_errors[c6c462034af138b3]::ErrorGuaranteed>>
  30:     0x7fef57f9ad30 - std[1177681641634ed6]::sys_common::backtrace::__rust_begin_short_backtrace::<rustc_interface[2af05e4c67454c01]::util::run_in_thread_pool_with_globals<rustc_interface[2af05e4c67454c01]::interface::run_compiler<core[3d15cbc1632fd665]::result::Result<(), rustc_errors[c6c462034af138b3]::ErrorGuaranteed>, rustc_driver[de5d577c9fbc1a01]::run_compiler::{closure#1}>::{closure#0}, core[3d15cbc1632fd665]::result::Result<(), rustc_errors[c6c462034af138b3]::ErrorGuaranteed>>::{closure#0}::{closure#0}, core[3d15cbc1632fd665]::result::Result<(), rustc_errors[c6c462034af138b3]::ErrorGuaranteed>>
  31:     0x7fef57f7bdbd - <<std[1177681641634ed6]::thread::Builder>::spawn_unchecked_<rustc_interface[2af05e4c67454c01]::util::run_in_thread_pool_with_globals<rustc_interface[2af05e4c67454c01]::interface::run_compiler<core[3d15cbc1632fd665]::result::Result<(), rustc_errors[c6c462034af138b3]::ErrorGuaranteed>, rustc_driver[de5d577c9fbc1a01]::run_compiler::{closure#1}>::{closure#0}, core[3d15cbc1632fd665]::result::Result<(), rustc_errors[c6c462034af138b3]::ErrorGuaranteed>>::{closure#0}::{closure#0}, core[3d15cbc1632fd665]::result::Result<(), rustc_errors[c6c462034af138b3]::ErrorGuaranteed>>::{closure#1} as core[3d15cbc1632fd665]::ops::function::FnOnce<()>>::call_once::{shim:vtable#0}