Rename wasm32-wasi to wasm32-wasi-preview1 by yoshuawuyts · Pull Request #110596 · rust-lang/rust (original) (raw)

I think the MCP mentioned the period where the old name would be accepted with the new name, but it looks like this PR just renames the target, without handling the old name in any way, why so?

@WaffleLapkin This is something we explicitly decided not to do. I think perhaps you might be confusing it with both Preview 1 and Preview 2 existing in the compiler for the foreseeable future? That was in the Preview 2 MCP. Relevant text from the Preview 1 rename MCP:

Because we are not (yet) removing a target but only renaming it, we should be able to do this over a regular Rust release. This means we are not going to have a period where the wasm32-wasi and wasm32-wasi-preview1 targets are both available in the toolchain.

Additionally I've found a few mentions of wasm32-wasi in the repo, that were not changed:

Oops! Thank you for spotting that! - The first and third one are reason other than I don't remember it showing up when I grepped the codebase.

The second one seems to be describing some sort of mapping of hashes and targets though. I actually don't know what that is, or how I should update that? Do I just rename the target, and will the hash remain the same? I could just try it and see what happens? I'll ask the bootstrap team on Zulip what to do with this.