Make slice iterators carry only a single provenance by scottmcm · Pull Request #122971 · rust-lang/rust (original) (raw)
Finished benchmarking commit (ea9961d): comparison URL.
Overall result: ❌✅ regressions and improvements - please read the text below
Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.
Next Steps: If you can justify the regressions found in this try perf run, please do so in sufficient writing along with @rustbot label: +perf-regression-triaged. If not, please fix the regressions and do another perf run. If its results are neutral or positive, the label will be automatically removed.
@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression
Instruction count
Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
| mean | range | count | |
|---|---|---|---|
| Regressions ❌ (primary) | 0.4% | [0.2%, 1.8%] | 138 |
| Regressions ❌ (secondary) | 0.4% | [0.1%, 0.8%] | 135 |
| Improvements ✅ (primary) | -0.5% | [-0.9%, -0.1%] | 12 |
| Improvements ✅ (secondary) | -1.8% | [-8.8%, -0.2%] | 7 |
| All ❌✅ (primary) | 0.3% | [-0.9%, 1.8%] | 150 |
Max RSS (memory usage)
Results (primary 2.2%, secondary 2.0%)
A less reliable metric. May be of interest, but not used to determine the overall result above.
| mean | range | count | |
|---|---|---|---|
| Regressions ❌ (primary) | 5.3% | [2.2%, 8.6%] | 3 |
| Regressions ❌ (secondary) | 2.0% | [1.0%, 2.8%] | 3 |
| Improvements ✅ (primary) | -2.4% | [-3.1%, -1.7%] | 2 |
| Improvements ✅ (secondary) | - | - | 0 |
| All ❌✅ (primary) | 2.2% | [-3.1%, 8.6%] | 5 |
Cycles
Results (primary 2.3%, secondary 3.2%)
A less reliable metric. May be of interest, but not used to determine the overall result above.
| mean | range | count | |
|---|---|---|---|
| Regressions ❌ (primary) | 2.3% | [2.1%, 2.4%] | 2 |
| Regressions ❌ (secondary) | 4.9% | [2.6%, 5.8%] | 4 |
| Improvements ✅ (primary) | - | - | 0 |
| Improvements ✅ (secondary) | -3.3% | [-3.3%, -3.3%] | 1 |
| All ❌✅ (primary) | 2.3% | [2.1%, 2.4%] | 2 |
Binary size
Results (primary -0.0%, secondary 0.0%)
A less reliable metric. May be of interest, but not used to determine the overall result above.
| mean | range | count | |
|---|---|---|---|
| Regressions ❌ (primary) | 0.2% | [0.0%, 1.0%] | 25 |
| Regressions ❌ (secondary) | 0.2% | [0.0%, 0.4%] | 81 |
| Improvements ✅ (primary) | -0.2% | [-0.8%, -0.0%] | 30 |
| Improvements ✅ (secondary) | -0.8% | [-7.5%, -0.0%] | 16 |
| All ❌✅ (primary) | -0.0% | [-0.8%, 1.0%] | 55 |
Bootstrap: 466.648s -> 465.651s (-0.21%)
Artifact size: 374.71 MiB -> 373.89 MiB (-0.22%)