Only collect mono items from reachable blocks by saethlin · Pull Request #123272 · rust-lang/rust (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation55 Commits2 Checks11 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

rustbot added S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

T-compiler

Relevant to the compiler team, which will review and decide on the PR/issue.

labels

Mar 31, 2024

This comment has been minimized.

bors added a commit to rust-lang-ci/rust that referenced this pull request

Mar 31, 2024

☀️ Try build successful - checks-actions
Build commit: 93c3b66 (93c3b66198cc1afa981b6b65c72f6ef987a1f619)

This comment has been minimized.

Finished benchmarking commit (93c3b66): comparison URL.

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean	range	count
Regressions ❌ (primary)	1.0%	[0.2%, 2.1%]	37
Regressions ❌ (secondary)	1.3%	[1.1%, 1.5%]	3
Improvements ✅ (primary)	-0.7%	[-1.2%, -0.2%]	8
Improvements ✅ (secondary)	-0.5%	[-0.6%, -0.3%]	6
All ❌✅ (primary)	0.7%	[-1.2%, 2.1%]	45

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean	range	count
Regressions ❌ (primary)	2.6%	[0.9%, 6.3%]	8
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-1.7%	[-3.3%, -0.2%]	2
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	1.8%	[-3.3%, 6.3%]	10

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean	range	count
Regressions ❌ (primary)	1.8%	[1.2%, 2.6%]	11
Regressions ❌ (secondary)	2.1%	[2.1%, 2.1%]	1
Improvements ✅ (primary)	-1.2%	[-1.6%, -0.7%]	3
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	1.2%	[-1.6%, 2.6%]	14

Binary size

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean	range	count
Regressions ❌ (primary)	0.1%	[0.0%, 0.3%]	7
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.3%	[-1.6%, -0.0%]	43
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-0.2%	[-1.6%, 0.3%]	50

Bootstrap: 666.819s -> 668.345s (0.23%)
Artifact size: 315.68 MiB -> 315.74 MiB (0.02%)

This comment has been minimized.

bors added a commit to rust-lang-ci/rust that referenced this pull request

Apr 1, 2024

☀️ Try build successful - checks-actions
Build commit: b1b76aa (b1b76aac3c9ca8c2e1809c6f0b624a26367ebcf2)

This comment has been minimized.

Finished benchmarking commit (b1b76aa): comparison URL.

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean	range	count
Regressions ❌ (primary)	0.6%	[0.2%, 1.2%]	28
Regressions ❌ (secondary)	0.6%	[0.6%, 0.7%]	3
Improvements ✅ (primary)	-0.8%	[-1.3%, -0.3%]	6
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.4%	[-1.3%, 1.2%]	34

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean	range	count
Regressions ❌ (primary)	2.2%	[0.5%, 5.2%]	14
Regressions ❌ (secondary)	1.6%	[1.4%, 1.9%]	3
Improvements ✅ (primary)	-1.3%	[-2.6%, -0.2%]	3
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	1.6%	[-2.6%, 5.2%]	17

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean	range	count
Regressions ❌ (primary)	1.2%	[0.9%, 1.5%]	2
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	1.2%	[0.9%, 1.5%]	2

Binary size

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean	range	count
Regressions ❌ (primary)	0.1%	[0.0%, 0.3%]	7
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.3%	[-1.6%, -0.0%]	44
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-0.2%	[-1.6%, 0.3%]	51

Bootstrap: 667.778s -> 668.661s (0.13%)
Artifact size: 315.75 MiB -> 315.71 MiB (-0.01%)

Great. There is actually measurable query overhead here.

This comment has been minimized.

bors added a commit to rust-lang-ci/rust that referenced this pull request

Apr 7, 2024

This comment has been minimized.

bors added S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

and removed S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

labels

Apr 7, 2024

Some changes occurred in compiler/rustc_codegen_cranelift

cc @bjorn3

This seems like a fiddly invariant to uphold in cg_clif. But also, this probably improves compile time especially of large programs when using cranelift. So maybe this is still a good idea. 🤷 @bjorn3 what do you think?

The cg_clif change seems fine to me.

📌 Commit b5b4928 has been approved by cjgillot

It is now in the queue for this repository.

bors added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

Apr 8, 2024

Finished benchmarking commit (bb78dba): comparison URL.

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please open an issue or create a new PR that fixes the regressions, add a comment linking to the newly created issue or PR, and then add the perf-regression-triaged label to this PR.

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean	range	count
Regressions ❌ (primary)	0.4%	[0.2%, 1.5%]	8
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.8%	[-1.5%, -0.3%]	6
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-0.1%	[-1.5%, 1.5%]	14

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean	range	count
Regressions ❌ (primary)	2.8%	[1.1%, 3.7%]	5
Regressions ❌ (secondary)	3.6%	[2.0%, 5.2%]	6
Improvements ✅ (primary)	-2.1%	[-2.1%, -2.1%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	2.0%	[-2.1%, 3.7%]	6

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean	range	count
Regressions ❌ (primary)	1.4%	[1.4%, 1.4%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-1.8%	[-1.9%, -1.6%]	2
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-0.7%	[-1.9%, 1.4%]	3

Binary size

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean	range	count
Regressions ❌ (primary)	0.1%	[0.0%, 0.4%]	7
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.3%	[-1.6%, -0.0%]	39
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-0.2%	[-1.6%, 0.4%]	46

Bootstrap: 674.109s -> 672.151s (-0.29%)
Artifact size: 318.37 MiB -> 318.39 MiB (0.00%)

fixed an important bug.
from the comment history, it looks like the minor restricted regressions were anticipated.
marking as triaged.

@rustbot label: +perf-regression-triaged

saethlin deleted the reachable-mono-cleanup branch

April 9, 2024 21:45

self.worklist.remove(idx);
if !self.visited.insert(idx) {
continue;
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is quadratic for the case where all blocks reference all earlier blocks, right?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could be. Would that be remarkable?