Set default value deny-warnings for compiler profile to false by WaffleLapkin · Pull Request #124439 · rust-lang/rust (original) (raw)

@compiler-errors thanks for providing your point of view, it differs from mine and so is interesting and useful to hear.

In my experience most warnings are not important, I usually get things like "unused import/function/variable/mut" while experimenting (especially unused import, I get this a lot since r-a auto adds imports but does not remove them automatically). And for those kinds of warnings it is silly to require rebuilding everything (fixing them require changing code, which causes a rebuild). This can be especially painful for contributors with ""low spec"" hardware, for whom a rebuild is a lot of time. (additionally denying warnings can fail compilation too early, not letting the compiler get to other warnings, in other crates)

As @Nilstrieb and @epage said already, it is common practice to deny warnings only in CI, to allow easier experimentation locally.

I can see the point that with the current system warnings can be easily lost. IMO a "CI fails with warnings, local has a warning summary at the end" would be ideal (summary referring to rust-lang/cargo#8749 (it's 4 years old, oof)).

As things stand, I think "x setup has a question about this" would be fine as well. (I do not have capacity to implement this though, is anyone up to this?)