Rewrite symlinked-extern, symlinked-rlib and symlinked-libraries run-make tests in rmake.rs format by Oneirical · Pull Request #125674 · rust-lang/rust (original) (raw)

@Oneirical @jieyouxu
These tests (symlinked-extern, symlinked-rlib, symlinked-libraries) are now failing on Windows for me.
The errors look like this:

thread 'main' panicked at C:\msys64\home\we\rust\src\tools\run-make-support\src\lib.rs:115:56:
failed to create symlink "other" for "libfoo.rlib": Os { code: 1314, kind: Uncategorized, message: "A required privilege is not held by the client." }

Symlink creation is a privileged operation (https://doc.rust-lang.org/stable/std/os/windows/fs/fn.symlink_file.html#limitations), it may be enabled on CI, but it's typically not enabled on user machines.

Standard library tests do not currently consider such failures fatal and treat the tests as ignored or passed, it would be better if run-make tests did the same thing.