Resolve Clippy f16 and f128 unimplemented!/FIXMEs by tgross35 · Pull Request #126636 · rust-lang/rust (original) (raw)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume it is to make sure there is a hash that depends only on the value and not the size, which , but I can't find anywhere that it is being used.

Unfortunately, I forgot that conversions to/from f16 aren't yet present on all platforms so I had to change this to just f.to_bits().hash(state);. I left a fixme here instead, maybe we could convert everything to f128 once that is better supported.