Change binary_asm_labels to only fire on x86 and x86_64 by tgross35 · Pull Request #127935 · rust-lang/rust (original) (raw)

In #126922, the binary_asm_labels lint was added which flags labels such as 0: and 1:. Before that change, LLVM was giving a confusing error on x86/x86_64 because of an incorrect interpretation.

However, targets other than x86 and x86_64 never had the error message and have not been a problem. This means that the lint was causing code that previously worked to start failing (e.g. compiler_builtins), rather than only providing a more clear messages where there has always been an error.

Adjust the lint to only fire on x86 and x86_64 assembly to avoid this regression.

Also update the help message.

Fixes: #127821