[Experimental] <T as Into<T>>::into lint by estebank · Pull Request #129249 · rust-lang/rust (original) (raw)
at 21:37:58 ❯ ./x.py clippy -Aclippy::all -Wclippy::useless_conversion
Building bootstrap
Finished `dev` profile [unoptimized] target(s) in 0.04s
Linting stage0 library {alloc, core, panic_abort, panic_unwind, proc_macro, std, sysroot, test, unwind} (x86_64-unknown-linux-gnu)
Compiling compiler_builtins v0.1.118
Checking core v0.0.0 (/home/matthias/vcs/github/rust/library/core)
Compiling libc v0.2.155
Compiling memchr v2.5.0
Compiling std v0.0.0 (/home/matthias/vcs/github/rust/library/std)
Checking rustc-std-workspace-core v1.99.0 (/home/matthias/vcs/github/rust/library/rustc-std-workspace-core)
Checking alloc v0.0.0 (/home/matthias/vcs/github/rust/library/alloc)
Checking cfg-if v1.0.0
Checking adler v1.0.2
Checking rustc-demangle v0.1.24
Checking unwind v0.0.0 (/home/matthias/vcs/github/rust/library/unwind)
Checking rustc-std-workspace-alloc v1.99.0 (/home/matthias/vcs/github/rust/library/rustc-std-workspace-alloc)
Checking panic_abort v0.0.0 (/home/matthias/vcs/github/rust/library/panic_abort)
Checking panic_unwind v0.0.0 (/home/matthias/vcs/github/rust/library/panic_unwind)
Checking gimli v0.29.0
Checking hashbrown v0.14.5
Checking object v0.36.2
Checking miniz_oxide v0.7.4
Checking std_detect v0.1.5 (/home/matthias/vcs/github/rust/library/stdarch/crates/std_detect)
Checking addr2line v0.22.0
warning: useless conversion to the same type: `i32`
--> std/src/os/unix/process.rs:333:9
|
333 | self.as_inner().into_raw().into()
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `self.as_inner().into_raw()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
= note: `-D clippy::useless-conversion` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::useless_conversion)]`
warning: useless conversion to the same type: `os::fd::owned::OwnedFd`
--> std/src/os/fd/owned.rs:331:9
|
331 | tcp_stream.into_inner().into_socket().into_inner().into_inner().into()
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `tcp_stream.into_inner().into_socket().into_inner().into_inner()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
warning: useless conversion to the same type: `os::fd::owned::OwnedFd`
--> std/src/os/fd/owned.rs:358:9
|
358 | tcp_listener.into_inner().into_socket().into_inner().into_inner().into()
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `tcp_listener.into_inner().into_socket().into_inner().into_inner()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
warning: useless conversion to the same type: `os::fd::owned::OwnedFd`
--> std/src/os/fd/owned.rs:385:9
|
385 | udp_socket.into_inner().into_socket().into_inner().into_inner().into()
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `udp_socket.into_inner().into_socket().into_inner().into_inner()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
warning: useless conversion to the same type: `usize`
--> std/src/sys/pal/unix/process/process_unix.rs:307:37
|
307 | cvt(libc::setgroups(_g.len().try_into().unwrap(), _g.as_ptr()))?;
| ^^^^^^^^^^^^^^^^^^^
|
= help: consider removing `.try_into()`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
warning: useless conversion to the same type: `io::error::Error`
--> std/src/sys/pal/unix/process/process_unix.rs:328:40
|
328 | ... return Err(e.into());
| ^^^^^^^^ help: consider removing `.into()`: `e`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
warning: useless conversion to the same type: `i64`
--> std/src/sys/pal/unix/time.rs:196:21
|
196 | tv_sec: self.tv_sec.try_into().ok()?,
| ^^^^^^^^^^^^^^^^^^^^^^
|
= help: consider removing `.try_into()`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
warning: useless conversion to the same type: `ffi::os_str::OsString`
--> std/src/sys_common/process.rs:38:31
|
38 | result.insert(k.into(), v);
| ^^^^^^^^ help: consider removing `.into()`: `k`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
warning: `std` (lib) generated 8 warnings (run `cargo clippy --fix --lib -p std` to apply 6 suggestions)
Checking rustc-std-workspace-std v1.99.0 (/home/matthias/vcs/github/rust/library/rustc-std-workspace-std)
Checking proc_macro v0.0.0 (/home/matthias/vcs/github/rust/library/proc_macro)
Checking unicode-width v0.1.13
Checking getopts v0.2.21
Checking test v0.0.0 (/home/matthias/vcs/github/rust/library/test)
Checking sysroot v0.0.0 (/home/matthias/vcs/github/rust/library/sysroot)
Finished `release` profile [optimized + debuginfo] target(s) in 35.62s
Checking stage0 library artifacts (x86_64-unknown-linux-gnu)
Compiling compiler_builtins v0.1.118
Compiling libc v0.2.155
Compiling memchr v2.5.0
Compiling std v0.0.0 (/home/matthias/vcs/github/rust/library/std)
Checking alloc v0.0.0 (/home/matthias/vcs/github/rust/library/alloc)
Checking cfg-if v1.0.0
Checking adler v1.0.2
Checking rustc-demangle v0.1.24
Checking unwind v0.0.0 (/home/matthias/vcs/github/rust/library/unwind)
Checking rustc-std-workspace-alloc v1.99.0 (/home/matthias/vcs/github/rust/library/rustc-std-workspace-alloc)
Checking panic_unwind v0.0.0 (/home/matthias/vcs/github/rust/library/panic_unwind)
Checking panic_abort v0.0.0 (/home/matthias/vcs/github/rust/library/panic_abort)
Checking gimli v0.29.0
Checking std_detect v0.1.5 (/home/matthias/vcs/github/rust/library/stdarch/crates/std_detect)
Checking object v0.36.2
Checking miniz_oxide v0.7.4
Checking hashbrown v0.14.5
Checking addr2line v0.22.0
Checking rustc-std-workspace-std v1.99.0 (/home/matthias/vcs/github/rust/library/rustc-std-workspace-std)
Checking proc_macro v0.0.0 (/home/matthias/vcs/github/rust/library/proc_macro)
Checking unicode-width v0.1.13
Checking getopts v0.2.21
Checking test v0.0.0 (/home/matthias/vcs/github/rust/library/test)
Checking sysroot v0.0.0 (/home/matthias/vcs/github/rust/library/sysroot)
Finished `release` profile [optimized + debuginfo] target(s) in 7.67s
Linting stage0 compiler {rustc-main, rustc_abi, rustc_arena, rustc_ast, rustc_ast_ir, rustc_ast_lowering, rustc_ast_passes, rustc_ast_pretty, rustc_attr, rustc_baked_icu_data, rustc_borrowck, rustc_builtin_macros, rustc_codegen_llvm, rustc_codegen_ssa, rustc_const_eval, rustc_data_structures, rustc_driver, rustc_driver_impl, rustc_error_codes, rustc_error_messages, rustc_errors, rustc_expand, rustc_feature, rustc_fluent_macro, rustc_fs_util, rustc_graphviz, rustc_hir, rustc_hir_analysis, rustc_hir_pretty, rustc_hir_typeck, rustc_incremental, rustc_index, rustc_index_macros, rustc_infer, rustc_interface, rustc_lexer, rustc_lint, rustc_lint_defs, rustc_llvm, rustc_log, rustc_macros, rustc_metadata, rustc_middle, rustc_mir_build, rustc_mir_dataflow, rustc_mir_transform, rustc_monomorphize, rustc_next_trait_solver, rustc_parse, rustc_parse_format, rustc_passes, rustc_pattern_analysis, rustc_privacy, rustc_query_impl, rustc_query_system, rustc_resolve, rustc_sanitizers, rustc_serialize, rustc_session, rustc_smir, rustc_span, rustc_symbol_mangling, rustc_target, rustc_trait_selection, rustc_traits, rustc_transmute, rustc_ty_utils, rustc_type_ir, rustc_type_ir_macros, stable_mir} (x86_64-unknown-linux-gnu)
Checking cfg-if v1.0.0
Checking once_cell v1.19.0
Checking stable_deref_trait v1.2.0
Checking smallvec v1.13.2
Checking either v1.12.0
Checking zerocopy v0.7.34
Checking allocator-api2 v0.2.18
Checking equivalent v1.0.1
Checking bitflags v2.5.0
Checking libc v0.2.155
Checking crossbeam-utils v0.8.20
Checking memchr v2.5.0
Checking log v0.4.21
Checking scopeguard v1.2.0
Checking typenum v1.17.0
Checking pin-project-lite v0.2.14
Checking rustc-hash v1.1.0
Checking zerofrom v0.1.4
Checking thin-vec v0.2.13
Checking lock_api v0.4.12
Checking linux-raw-sys v0.4.14
Checking arrayvec v0.7.4
Checking tracing-core v0.1.30
Checking psm v0.1.21
Checking fastrand v2.1.0
Checking yoke v0.7.4
Checking ena v0.14.3
Checking rustc_arena v0.0.0 (/home/matthias/vcs/github/rust/compiler/rustc_arena)
Checking elsa v1.7.1
Checking cpufeatures v0.2.12
Checking unicode-width v0.1.13
Checking ahash v0.8.11
Checking rustc_graphviz v0.0.0 (/home/matthias/vcs/github/rust/compiler/rustc_graphviz)
Checking itoa v1.0.11
Checking rustc-stable-hash v0.1.0
Checking scoped-tls v1.0.1
Checking ppv-lite86 v0.2.17
Checking crc32fast v1.4.2
Checking zerovec v0.10.2
Checking writeable v0.5.5
Checking crossbeam-epoch v0.9.18
Checking crossbeam-channel v0.5.13
Checking litemap v0.7.3
Checking serde v1.0.203
Checking unicode-xid v0.2.4
Checking unicode-properties v0.1.1
Checking tracing v0.1.37
Checking rustix v0.38.34
Checking wasmparser v0.214.0
Checking hashbrown v0.14.5
Checking icu_locid_transform_data v1.5.0
Checking ryu v1.0.18
Checking thiserror v1.0.61
Checking rustc_lexer v0.0.0 (/home/matthias/vcs/github/rust/compiler/rustc_lexer)
Checking regex-automata v0.2.0
Checking generic-array v0.14.7
Checking type-map v0.5.0
Checking rustc_fs_util v0.0.0 (/home/matthias/vcs/github/rust/compiler/rustc_fs_util)
Checking self_cell v1.0.4
Checking crossbeam-deque v0.8.5
Checking icu_list_data v1.5.0
Checking fluent-syntax v0.11.1
Checking odht v0.3.1
Checking self_cell v0.10.3
Checking itertools v0.12.1
Checking anstyle v1.0.7
Checking rustc_error_codes v0.0.0 (/home/matthias/vcs/github/rust/compiler/rustc_error_codes)
Checking termcolor v1.4.1
Checking getopts v0.2.21
Checking memoffset v0.9.1
Checking bitflags v1.3.2
Checking datafrog v2.0.1
Checking rustc_apfloat v0.2.0+llvm-462a31f5a5ab
Checking field-offset v0.3.6
Checking annotate-snippets v0.10.2
Checking tinyvec_macros v0.1.1
Checking aho-corasick v1.1.3
Checking regex-syntax v0.7.5
Checking static_assertions v1.1.0
Checking tinyvec v1.6.0
Checking adler v1.0.2
Checking byteorder v1.5.0
Checking block-buffer v0.10.4
Checking crypto-common v0.1.6
Checking polonius-engine v0.13.0
Checking miniz_oxide v0.7.4
Checking unicode-script v0.5.6
Checking num_cpus v1.16.0
Checking parking_lot_core v0.9.10
Checking tinystr v0.7.6
Checking digest v0.10.7
Checking perf-event-open-sys v3.0.0
Checking memmap2 v0.2.3
Checking rustc-rayon-core v0.5.0
Checking parking_lot v0.12.3
Checking jobserver v0.1.31
Checking stacker v0.1.15
Checking getrandom v0.2.15
Checking sha2 v0.10.8
Checking md-5 v0.10.6
Checking sha1 v0.10.6
Checking unic-langid-impl v0.9.5
Checking measureme v11.0.1
Checking icu_locid v1.5.0
Checking rand_core v0.6.4
Checking termize v0.1.1
Checking snap v1.1.1
Checking flate2 v1.0.30
Checking libloading v0.8.3
Checking unic-langid-macros v0.9.5
Checking rand_chacha v0.3.1
Checking rand_xoshiro v0.6.0
Checking unic-langid v0.9.5
Checking regex-syntax v0.6.29
Checking unicode-normalization v0.1.23
Checking rustc-rayon v0.5.0
Checking fluent-langneg v0.13.0
Checking intl_pluralrules v7.0.2
Checking intl-memoizer v0.5.2
Checking rustc-demangle v0.1.24
Checking rand v0.8.5
Checking lazy_static v1.5.0
Checking punycode v0.4.1
Checking tempfile v3.10.1
Checking leb128 v0.2.5
Checking overload v0.1.1
Checking sharded-slab v0.1.7
Checking unicase v2.7.0
Checking wasm-encoder v0.210.0
Checking thread_local v1.1.8
Checking nu-ansi-term v0.46.0
Checking icu_provider v1.5.0
Checking fluent-bundle v0.15.3
Checking pathdiff v0.2.1
Checking cc v1.0.99
Checking pulldown-cmark-escape v0.11.0
Checking rustc_llvm v0.0.0 (/home/matthias/vcs/github/rust/compiler/rustc_llvm)
Checking tracing-log v0.2.0
Checking unicode-security v0.1.1
Checking powerfmt v0.2.0
Checking pulldown-cmark v0.11.0
Checking nu-ansi-term v0.50.0
Checking nix v0.28.0
Checking deranged v0.3.11
Checking icu_locid_transform v1.5.0
Checking time-core v0.1.2
Checking num-conv v0.1.0
Checking twox-hash v1.6.3
Checking shlex v1.3.0
Checking regex-automata v0.3.7
Checking ruzstd v0.5.0
Checking serde_json v1.0.117
Checking gsgdt v0.1.2
Checking stable_mir v0.1.0-preview (/home/matthias/vcs/github/rust/compiler/stable_mir)
Checking icu_list v1.5.0
Checking icu_provider_adapters v1.5.0
Checking time v0.3.36
Checking ctrlc v3.4.4
Checking regex-automata v0.1.10
Checking indexmap v2.4.0
Checking rustc_baked_icu_data v0.0.0 (/home/matthias/vcs/github/rust/compiler/rustc_baked_icu_data)
Checking matchers v0.1.0
Checking rustc_serialize v0.0.0 (/home/matthias/vcs/github/rust/compiler/rustc_serialize)
Checking object v0.36.2
Checking object v0.32.2
Checking gimli v0.28.1
Checking regex v1.9.4
Checking rustc_index v0.0.0 (/home/matthias/vcs/github/rust/compiler/rustc_index)
Checking tracing-subscriber v0.3.18
Checking rustc_data_structures v0.0.0 (/home/matthias/vcs/github/rust/compiler/rustc_data_structures)
Checking rustc_parse_format v0.0.0 (/home/matthias/vcs/github/rust/compiler/rustc_parse_format)
Checking tracing-tree v0.3.1
Checking rustc_log v0.0.0 (/home/matthias/vcs/github/rust/compiler/rustc_log)
Checking rustc_span v0.0.0 (/home/matthias/vcs/github/rust/compiler/rustc_span)
Checking rustc_abi v0.0.0 (/home/matthias/vcs/github/rust/compiler/rustc_abi)
Checking thorin-dwp v0.7.0
Checking ar_archive_writer v0.4.0
Checking rustc_ast_ir v0.0.0 (/home/matthias/vcs/github/rust/compiler/rustc_ast_ir)
Checking rustc_feature v0.0.0 (/home/matthias/vcs/github/rust/compiler/rustc_feature)
Checking rustc_error_messages v0.0.0 (/home/matthias/vcs/github/rust/compiler/rustc_error_messages)
Checking rustc_ast v0.0.0 (/home/matthias/vcs/github/rust/compiler/rustc_ast)
Checking rustc_type_ir v0.0.0 (/home/matthias/vcs/github/rust/compiler/rustc_type_ir)
Checking rustc_target v0.0.0 (/home/matthias/vcs/github/rust/compiler/rustc_target)
warning: useless conversion to the same type: `ast::StaticItem`
--> compiler/rustc_ast/src/ast.rs:3467:43
|
3467 | ItemKind::Static(Box::new(static_foreign_item.into()))
| ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `static_foreign_item`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
= note: `-D clippy::useless-conversion` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::useless_conversion)]`
warning: useless conversion to the same type: `ast::StaticItem`
--> compiler/rustc_ast/src/ast.rs:3482:50
|
3482 | ForeignItemKind::Static(Box::new(static_item.into()))
| ^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `static_item`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
warning: `rustc_ast` (lib) generated 2 warnings (run `cargo clippy --fix --lib -p rustc_ast` to apply 2 suggestions)
Checking rustc_ast_pretty v0.0.0 (/home/matthias/vcs/github/rust/compiler/rustc_ast_pretty)
Checking rustc_next_trait_solver v0.0.0 (/home/matthias/vcs/github/rust/compiler/rustc_next_trait_solver)
warning: useless conversion to the same type: `impl std::iter::Iterator<Item = <I as rustc_type_ir::Interner>::DefId>`
--> compiler/rustc_next_trait_solver/src/solve/trait_goals.rs:878:17
|
878 | / elaborate::supertrait_def_ids(self.cx(), principal_def_id)
879 | | .into_iter()
| |________________________________^ help: consider removing `.into_iter()`: `elaborate::supertrait_def_ids(self.cx(), principal_def_id)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
= note: `-D clippy::useless-conversion` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::useless_conversion)]`
warning: `rustc_next_trait_solver` (lib) generated 1 warning (run `cargo clippy --fix --lib -p rustc_next_trait_solver` to apply 1 suggestion)
Checking rustc_hir v0.0.0 (/home/matthias/vcs/github/rust/compiler/rustc_hir)
Checking rustc_lint_defs v0.0.0 (/home/matthias/vcs/github/rust/compiler/rustc_lint_defs)
Checking rustc_hir_pretty v0.0.0 (/home/matthias/vcs/github/rust/compiler/rustc_hir_pretty)
Checking rustc_errors v0.0.0 (/home/matthias/vcs/github/rust/compiler/rustc_errors)
warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator`
--> compiler/rustc_errors/src/diagnostic.rs:709:20
|
709 | msg.extend(expected.0.into_iter());
| ^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `expected.0`
|
note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()`
--> /home/matthias/vcs/github/rust/library/core/src/iter/traits/collect.rs:450:18
|
450 | fn extend<T: IntoIterator<Item = A>>(&mut self, iter: T);
| ^^^^^^^^^^^^^^^^^^^^^^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
= note: `-D clippy::useless-conversion` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::useless_conversion)]`
warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator`
--> compiler/rustc_errors/src/diagnostic.rs:712:20
|
712 | msg.extend(found.0.into_iter());
| ^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `found.0`
|
note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()`
--> /home/matthias/vcs/github/rust/library/core/src/iter/traits/collect.rs:450:18
|
450 | fn extend<T: IntoIterator<Item = A>>(&mut self, iter: T);
| ^^^^^^^^^^^^^^^^^^^^^^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
warning: `rustc_errors` (lib) generated 2 warnings (run `cargo clippy --fix --lib -p rustc_errors` to apply 2 suggestions)
Checking rustc_session v0.0.0 (/home/matthias/vcs/github/rust/compiler/rustc_session)
Checking rustc_attr v0.0.0 (/home/matthias/vcs/github/rust/compiler/rustc_attr)
Checking rustc_query_system v0.0.0 (/home/matthias/vcs/github/rust/compiler/rustc_query_system)
Checking rustc_parse v0.0.0 (/home/matthias/vcs/github/rust/compiler/rustc_parse)
Checking rustc_middle v0.0.0 (/home/matthias/vcs/github/rust/compiler/rustc_middle)
warning: useless conversion to the same type: `rustc_ast::Recovered`
--> compiler/rustc_parse/src/parser/item.rs:1589:58
|
1589 | VariantData::Struct { fields, recovered: recovered.into() }
| ^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `recovered`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
= note: `-D clippy::useless-conversion` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::useless_conversion)]`
warning: useless conversion to the same type: `rustc_ast::Recovered`
--> compiler/rustc_parse/src/parser/item.rs:1673:58
|
1673 | VariantData::Struct { fields, recovered: recovered.into() }
| ^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `recovered`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
warning: useless conversion to the same type: `rustc_ast::Recovered`
--> compiler/rustc_parse/src/parser/item.rs:1685:54
|
1685 | VariantData::Struct { fields, recovered: recovered.into() }
| ^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `recovered`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
warning: useless conversion to the same type: `rustc_ast::Recovered`
--> compiler/rustc_parse/src/parser/item.rs:1714:54
|
1714 | VariantData::Struct { fields, recovered: recovered.into() }
| ^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `recovered`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
warning: useless conversion to the same type: `rustc_ast::Recovered`
--> compiler/rustc_parse/src/parser/item.rs:1721:54
|
1721 | VariantData::Struct { fields, recovered: recovered.into() }
| ^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `recovered`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
warning: `rustc_parse` (lib) generated 5 warnings (run `cargo clippy --fix --lib -p rustc_parse` to apply 5 suggestions)
Checking rustc_ast_passes v0.0.0 (/home/matthias/vcs/github/rust/compiler/rustc_ast_passes)
Checking rustc_expand v0.0.0 (/home/matthias/vcs/github/rust/compiler/rustc_expand)
Checking rustc_builtin_macros v0.0.0 (/home/matthias/vcs/github/rust/compiler/rustc_builtin_macros)
warning: useless conversion to the same type: `rustc_ast::BinOpKind`
--> compiler/rustc_middle/src/ty/print/pretty.rs:1529:45
|
1529 | AssocOp::from_ast_binop(binop.to_hir_binop().into()).precedence()
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `binop.to_hir_binop()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
= note: `-D clippy::useless-conversion` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::useless_conversion)]`
warning: useless conversion to the same type: `mir::interpret::error::ErrorHandled`
--> compiler/rustc_middle/src/ty/consts.rs:387:51
|
387 | Err(err) => Err(Either::Right(err.into())),
| ^^^^^^^^^^ help: consider removing `.into()`: `err`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
warning: `rustc_middle` (lib) generated 2 warnings (run `cargo clippy --fix --lib -p rustc_middle` to apply 2 suggestions)
Checking rustc_infer v0.0.0 (/home/matthias/vcs/github/rust/compiler/rustc_infer)
Checking rustc_mir_dataflow v0.0.0 (/home/matthias/vcs/github/rust/compiler/rustc_mir_dataflow)
Checking rustc_metadata v0.0.0 (/home/matthias/vcs/github/rust/compiler/rustc_metadata)
Checking rustc_pattern_analysis v0.0.0 (/home/matthias/vcs/github/rust/compiler/rustc_pattern_analysis)
Checking rustc_symbol_mangling v0.0.0 (/home/matthias/vcs/github/rust/compiler/rustc_symbol_mangling)
Checking rustc_incremental v0.0.0 (/home/matthias/vcs/github/rust/compiler/rustc_incremental)
Checking rustc_monomorphize v0.0.0 (/home/matthias/vcs/github/rust/compiler/rustc_monomorphize)
Checking rustc_ast_lowering v0.0.0 (/home/matthias/vcs/github/rust/compiler/rustc_ast_lowering)
Checking rustc_query_impl v0.0.0 (/home/matthias/vcs/github/rust/compiler/rustc_query_impl)
Checking rustc_smir v0.0.0 (/home/matthias/vcs/github/rust/compiler/rustc_smir)
warning: useless conversion to the same type: `rustc_middle::ty::Const<'_>`
--> compiler/rustc_symbol_mangling/src/v0.rs:385:25
|
385 | ty::Const::from_bool(self.tcx, include_end).into(),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `ty::Const::from_bool(self.tcx, include_end)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
= note: `-D clippy::useless-conversion` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::useless_conversion)]`
warning: `rustc_symbol_mangling` (lib) generated 1 warning (run `cargo clippy --fix --lib -p rustc_symbol_mangling` to apply 1 suggestion)
Checking rustc_codegen_ssa v0.0.0 (/home/matthias/vcs/github/rust/compiler/rustc_codegen_ssa)
Checking rustc_resolve v0.0.0 (/home/matthias/vcs/github/rust/compiler/rustc_resolve)
Checking rustc_transmute v0.0.0 (/home/matthias/vcs/github/rust/compiler/rustc_transmute)
Checking rustc_trait_selection v0.0.0 (/home/matthias/vcs/github/rust/compiler/rustc_trait_selection)
warning: useless conversion to the same type: `rustc_middle::ty::Term<'_>`
--> compiler/rustc_trait_selection/src/traits/project.rs:409:28
|
409 | return Ok(Some(result.value.into()));
| ^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `result.value`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
= note: `-D clippy::useless-conversion` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::useless_conversion)]`
warning: useless conversion to the same type: `rustc_middle::ty::Term<'_>`
--> compiler/rustc_trait_selection/src/traits/project.rs:479:21
|
479 | Ok(Some(result.value.into()))
| ^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `result.value`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
warning: `rustc_trait_selection` (lib) generated 2 warnings (run `cargo clippy --fix --lib -p rustc_trait_selection` to apply 2 suggestions)
Checking rustc_lint v0.0.0 (/home/matthias/vcs/github/rust/compiler/rustc_lint)
Checking rustc_ty_utils v0.0.0 (/home/matthias/vcs/github/rust/compiler/rustc_ty_utils)
Checking rustc_const_eval v0.0.0 (/home/matthias/vcs/github/rust/compiler/rustc_const_eval)
Checking rustc_sanitizers v0.0.0 (/home/matthias/vcs/github/rust/compiler/rustc_sanitizers)
Checking rustc_hir_analysis v0.0.0 (/home/matthias/vcs/github/rust/compiler/rustc_hir_analysis)
Checking rustc_traits v0.0.0 (/home/matthias/vcs/github/rust/compiler/rustc_traits)
Checking rustc_borrowck v0.0.0 (/home/matthias/vcs/github/rust/compiler/rustc_borrowck)
Checking rustc_codegen_llvm v0.0.0 (/home/matthias/vcs/github/rust/compiler/rustc_codegen_llvm)
Checking rustc_privacy v0.0.0 (/home/matthias/vcs/github/rust/compiler/rustc_privacy)
Checking rustc_passes v0.0.0 (/home/matthias/vcs/github/rust/compiler/rustc_passes)
warning: useless conversion to the same type: `interpret::place::MPlaceTy<'_>`
--> compiler/rustc_const_eval/src/const_eval/eval_queries.rs:81:10
|
81 | &ret.clone().into(),
| ^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `ret.clone()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
= note: `-D clippy::useless-conversion` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::useless_conversion)]`
warning: useless conversion to the same type: `interpret::place::MPlaceTy<'_, <M as interpret::machine::Machine<'_>>::Provenance>`
--> compiler/rustc_const_eval/src/interpret/call.rs:857:14
|
857 | &ret.into(),
| ^^^^^^^^^^ help: consider removing `.into()`: `ret`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
Checking rustc_mir_build v0.0.0 (/home/matthias/vcs/github/rust/compiler/rustc_mir_build)
warning: `rustc_const_eval` (lib) generated 2 warnings (run `cargo clippy --fix --lib -p rustc_const_eval` to apply 2 suggestions)
warning: useless conversion to the same type: `usize`
--> compiler/rustc_hir_analysis/src/check/wfcheck.rs:1604:32
|
1604 | param_idx: idx.try_into().unwrap(),
| ^^^^^^^^^^^^^^
|
= help: consider removing `.try_into()`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
= note: `-D clippy::useless-conversion` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::useless_conversion)]`
warning: useless conversion to the same type: `usize`
--> compiler/rustc_hir_analysis/src/check/wfcheck.rs:1613:70
|
1613 | Some(WellFormedLoc::Param { function: def_id, param_idx: idx.try_into().unwrap() }),
| ^^^^^^^^^^^^^^
|
= help: consider removing `.try_into()`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
warning: `rustc_hir_analysis` (lib) generated 2 warnings
Checking rustc_hir_typeck v0.0.0 (/home/matthias/vcs/github/rust/compiler/rustc_hir_typeck)
Checking rustc_mir_transform v0.0.0 (/home/matthias/vcs/github/rust/compiler/rustc_mir_transform)
warning: useless conversion to the same type: `usize`
--> compiler/rustc_hir_typeck/src/fn_ctxt/checks.rs:2536:35
|
2536 | idxs_matched.push(other_idx.into());
| ^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `other_idx`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
= note: `-D clippy::useless-conversion` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::useless_conversion)]`
warning: `rustc_hir_typeck` (lib) generated 1 warning (run `cargo clippy --fix --lib -p rustc_hir_typeck` to apply 1 suggestion)
Checking rustc_interface v0.0.0 (/home/matthias/vcs/github/rust/compiler/rustc_interface)
Checking rustc_driver_impl v0.0.0 (/home/matthias/vcs/github/rust/compiler/rustc_driver_impl)
Checking rustc_driver v0.0.0 (/home/matthias/vcs/github/rust/compiler/rustc_driver)
Checking rustc-main v0.0.0 (/home/matthias/vcs/github/rust/compiler/rustc)
Finished `release` profile [optimized + debuginfo] target(s) in 1m 22s
Build completed successfully in 0:02:07