riscv64imac: allow shadow call stack sanitizer by dingxiangfei2009 · Pull Request #129316 · rust-lang/rust (original) (raw)

Actualy, I'd suggest rewriting the bulk of the shadow stack documentation to more closely align w/ what's in LLVM: https://clang.llvm.org/docs/ShadowCallStack.html#id6. Before we added RISC-V support, our docs were also very Aarch64 centric, and it seems like the Rust versions were closely following the old version. I'd also suggest that at least some of the descriptions in the fixed-x18.md be moved to a shadwow-call-stack.md file, and discuss the overall picture of SCS, rather than the vagaries of the Aarch64 ABI. Those details have a place, but have equivalents in other architectures, like RISC-V, so I think it would be best to organize them accordingly. I'm happy to help w/ that, but I'm not sure I'll have time for a PR before next week.