Remove unstable cfg target(...) compact feature by Urgau · Pull Request #130780 · rust-lang/rust (original) (raw)

So, strictly speaking, removing something unstable from the compiler doesn't need our lang OK. If compiler wants to say, "we're not happy with the implementation, we're going to pull it out until someone tries again", or "this is in the way, and it's not on track to be stabilized soon, so we're going to pull it out", then that can just be done, though we appreciate a heads-up and CC on it, especially if it's in the critical path of something on our radar.

On this one though, I do read it as a lang request. (This is what I think you had in mind also; I'm saying this all for the benefit of others.) The implementation seems fine, and it's not a lot of code, and it doesn't seem in the way of anything. So it's basically just a prompt to ask the lang question of whether this is something we still want or not.

In that light, this is nominated, and we'll try to get to it (no promises on timing), but also, let's ping everyone and maybe we'll collect some thoughts.

@rust-lang/lang: What do we think? Do we still want #[cfg(target(..))]?