Fix target_vendor for aarch64-nintendo-switch-freestanding by madsmtm · Pull Request #131166 · rust-lang/rust (original) (raw)

EDIT: Actually based on the reference https://doc.rust-lang.org/reference/conditional-compilation.html#target_env:

Key-value option set with further disambiguating information about the target platform with information about the ABI or libc used. For historical reasons, this value is only defined as not the empty-string when actually needed for disambiguation. Thus, for example, on many GNU platforms, this value will be empty. This value is similar to the fourth element of the platform’s target triple. One difference is that embedded ABIs such as gnueabihf will simply define target_env as "gnu".

Let's not include the target_env = "freestanding" change for now, as based on existing usage patterns it seems like it's more about the libc used: "gnu", "msvc", "musl", "sgx" etc. Specifically, I don't think we need this string for disambiguation yet, and we can always adjust this in the future if there's another target that needs disambiguation from the eixsting aarch64-nintendo-switch-freestanding target.

r=me after removing target_env changes, sorry for the confusion.