Support clobber_abi in MSP430 inline assembly by taiki-e · Pull Request #131310 · rust-lang/rust (original) (raw)

@cr1901

• Should clobber_abi also support abi-msp430-interrupt?

Thanks for pointing that out, I missed that because it is unstable. However, it appears that *-interrupt ABIs are not currently supported in clobber_abi on other architectures as well. (Since dependence on other unstable features may prevent stabilization, their lack of support is maybe intentional.)

"x86-interrupt",
"avr-interrupt",
"avr-non-blocking-interrupt",
"riscv-interrupt-m",
"riscv-interrupt-s",

x86/x86_64:

riscv:

(clobber_abi for AVR is not yet supported)

• Why is this not call void asm sideeffect, and only asm sideeffect?

This is because it is not a call void asm, but a very long one: call { i16, i16, i16, i16, i16 } asm

That test is based on the same test for s390x added in #130630, and call ... asm for s390x was call { i32, i32, i32, i32, i32, i32, i32, double, double, double, double, double, double, double, double } asm.
In #130630, I had originally intended to write everything call ..., but realized it would be too long for clobber_abi and omitted it. I left it at the other ones (flags and clobber-only registers) because I thought if they were not call void asm, something was wrong.

FYI, for x86_64, it is call { i32, i32, i32, i32, i32, i32, i32, i32, i32, float, float, float, float, float, float, float, float, float, float, float, float, float, float, float, float } asm,
and call ... asm sideeffect "", is omitted in codegen test for clobber_abi: