Correctly rounded floating point `div_euclid`. by tczajka · Pull Request #134145 · rust-lang/rust (original) (raw)

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

rustbot added S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

Relevant to the library team, which will review and decide on the PR/issue.

labels

f{16,32,64,128}/soft.rs are now very similar. f32 and f64 almost identical.

U256 helper moved to crate::u256.

(-5f32).div_euclid(f32::INFINITY) now returns -1 not 0.

jieyouxu added the T-libs-api

Relevant to the library API team, which will review and decide on the PR/issue.

label

Comment on lines +245 to +247

Comment on lines +278 to +280

rustbot added S-waiting-on-author

Status: This is awaiting some action (such as code changes or more information) from the author.

and removed S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

Comment on lines +12 to +17

Comment on lines +12 to +22

Comment on lines +30 to +61