coverage: Dismantle map_data.rs by moving its responsibilities elsewhere by Zalathar · Pull Request #134323 · rust-lang/rust (original) (raw)

This is a series of incremental changes that combine to let us get rid of coverageinfo/map_data.rs, by moving all of its responsibilities into more appropriate places.

Some of the notable consequences are:

• We once again build the per-CGU file table on the fly while preparing individual covfun records, instead of building the whole table up-front. The up-front approach was introduced by coverage: Emit the filenames section before encoding per-function mappings #117042 to work around various other problems in generating the covmap/covfun records, but subsequent cleanups have made that approach no longer necessary.
• Expression conversion and mapping-region conversion are now performed directly in mapgen::covfun, which should make future changes easier.
• We no longer insert unused function instances into the same map that is also used to track used function instances. This helps to decouple the handling of used vs unused functions.

There should be no meaningful change to compiler output. The file table is no longer sorted, because reordering it would invalidate the file indices stored in individual covfun records, but the table order should still be deterministic (albeit arbitrary).

There are some subsequent cleanups that I intend to investigate, but this is enough change for one PR.