Treat safe target_feature functions as unsafe by default [less invasive variant] by oli-obk · Pull Request #134353 · rust-lang/rust (original) (raw)
Finished benchmarking commit (341f603): comparison URL.
Overall result: ❌ regressions - no action needed
@rustbot label: -perf-regression
Instruction count
This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.
mean | range | count | |
---|---|---|---|
Regressions ❌ (primary) | 0.0% | [0.0%, 0.0%] | 1 |
Regressions ❌ (secondary) | - | - | 0 |
Improvements ✅ (primary) | - | - | 0 |
Improvements ✅ (secondary) | - | - | 0 |
All ❌✅ (primary) | 0.0% | [0.0%, 0.0%] | 1 |
Max RSS (memory usage)
Results (primary -3.1%, secondary 0.6%)
This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
mean | range | count | |
---|---|---|---|
Regressions ❌ (primary) | - | - | 0 |
Regressions ❌ (secondary) | 2.8% | [2.2%, 3.3%] | 2 |
Improvements ✅ (primary) | -3.1% | [-3.1%, -3.1%] | 1 |
Improvements ✅ (secondary) | -3.8% | [-3.8%, -3.8%] | 1 |
All ❌✅ (primary) | -3.1% | [-3.1%, -3.1%] | 1 |
Cycles
Results (secondary 7.2%)
This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
mean | range | count | |
---|---|---|---|
Regressions ❌ (primary) | - | - | 0 |
Regressions ❌ (secondary) | 7.2% | [7.2%, 7.2%] | 1 |
Improvements ✅ (primary) | - | - | 0 |
Improvements ✅ (secondary) | - | - | 0 |
All ❌✅ (primary) | - | - | 0 |
Binary size
Results (primary 0.0%, secondary 0.2%)
This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
mean | range | count | |
---|---|---|---|
Regressions ❌ (primary) | 0.0% | [0.0%, 0.1%] | 54 |
Regressions ❌ (secondary) | 0.2% | [0.0%, 0.4%] | 21 |
Improvements ✅ (primary) | - | - | 0 |
Improvements ✅ (secondary) | - | - | 0 |
All ❌✅ (primary) | 0.0% | [0.0%, 0.1%] | 54 |
Bootstrap: 764.012s -> 762.915s (-0.14%)
Artifact size: 326.03 MiB -> 326.09 MiB (0.02%)