rust (original) (raw)

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

rustbot added S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

T-compiler

Relevant to the compiler team, which will review and decide on the PR/issue.

labels

Dec 23, 2024

[commit does not pass tests]

removed special-case logic for a few cases (including the unit type, which is now only checked for in one place)
moved a lot of type-checking code in their dedicated visit_* methods
reworked FfiResult type to handle multiple diagnostics per type (currently imperfect due to type caching)
reworked the messages around CStr and CString