Remove outdated comment about std::hash::DefaultHasher being inaccessible by dbdr · Pull Request #135735 · rust-lang/rust (original) (raw)
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @ibraheemdev (or someone else) some time within the next two weeks.
Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:
@rustbot author: the review is finished, PR author should check the comments and take action accordingly@rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue
Status: Awaiting review from the assignee but also interested parties.
Relevant to the library team, which will review and decide on the PR/issue.
labels
| @@ -2,9 +2,6 @@ |
|---|
| //! [`collections`] module without actually publicly exporting them, so that parts of that |
| //! implementation can more easily be moved to the [`alloc`] crate. |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like this comment is outdated too.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are right. So should this entire module be unmoduled and inlined into another file?
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comment on lines -5 to -7
| //! Although its items are public and contain stability attributes, they can't actually be accessed |
|---|
| //! outside this crate. |
| //! |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Taking a closer look, I think the comments are actually correct. This module was added in #115694 for the reasons the comment mentions. I think we can confusion by mentioning that the types are re-exported elsewhere.
- //! Although its items are public and contain stability attributes, they can't actually be accessed
- //! outside this crate.
- //! Although its items are public and contain stability attributes, they can't actually be accessed
- //! through this module, and are instead re-exported from
std::hashandstd::collections::hash_map.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dbdr
Thanks for your contribution.
From wg-triage, please check out the feedback given by the reviewers.
Thanks again!