Add new tool for dumping feature status based on tidy by yaahc · Pull Request #135844 · rust-lang/rust (original) (raw)
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes looked good to me, so I checked out your branch locally to test. Only two tiny issues that I needed to change to get the check and run steps to work properly, so I pushed the fix to your branch (and slightly adjusted the commit history). Let me know what you think, otherwise r=me and you.
With the two fixes to get it to build, I tested these locally:
./x check src/tools/features-status-dump
... OK./x check src/tools/features-status-dump
(unmodified re-run)... OK./x check src/tools/features-status-dump
(modified)... OK, REBUILDS./x run src/tools/features-status-dump
... OK, produces a JSON underbuild/
./x run src/tools/features-status-dump
(modified)... OK, REBUILDS