Implement String::make_(upp|low)ercase by krtab · Pull Request #135888 · rust-lang/rust (original) (raw)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't required for this PR, but for completeness, it would be nice to make this change to the next_code_point_reverse function as well, also offering a next_code_point_reverse_with_width function that provides the width. I do have a version I've written that I use in the implementation I proposed in Zulip, so, it would likely be used in the final implementation.

That said, you don't need to make this change now since it isn't strictly required for the first pass. Just figured I'd mention it.