Start using pattern types in libcore by oli-obk · Pull Request #136006 · rust-lang/rust (original) (raw)
Finished benchmarking commit (e177b34): comparison URL.
Overall result: ❌✅ regressions and improvements - please read the text below
Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.
Next Steps: If you can justify the regressions found in this try perf run, please do so in sufficient writing along with @rustbot label: +perf-regression-triaged. If not, please fix the regressions and do another perf run. If its results are neutral or positive, the label will be automatically removed.
@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression
Instruction count
Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
| mean | range | count | |
|---|---|---|---|
| Regressions ❌ (primary) | 1.5% | [0.2%, 3.4%] | 17 |
| Regressions ❌ (secondary) | 0.9% | [0.1%, 3.4%] | 12 |
| Improvements ✅ (primary) | -0.6% | [-2.8%, -0.2%] | 11 |
| Improvements ✅ (secondary) | -0.7% | [-1.2%, -0.3%] | 2 |
| All ❌✅ (primary) | 0.7% | [-2.8%, 3.4%] | 28 |
Max RSS (memory usage)
Results (primary -0.0%, secondary -2.3%)
A less reliable metric. May be of interest, but not used to determine the overall result above.
| mean | range | count | |
|---|---|---|---|
| Regressions ❌ (primary) | 3.1% | [1.5%, 5.0%] | 3 |
| Regressions ❌ (secondary) | 2.2% | [1.2%, 3.0%] | 3 |
| Improvements ✅ (primary) | -4.7% | [-4.7%, -4.7%] | 2 |
| Improvements ✅ (secondary) | -3.7% | [-4.9%, -1.4%] | 10 |
| All ❌✅ (primary) | -0.0% | [-4.7%, 5.0%] | 5 |
Cycles
Results (primary -1.3%, secondary -1.4%)
A less reliable metric. May be of interest, but not used to determine the overall result above.
| mean | range | count | |
|---|---|---|---|
| Regressions ❌ (primary) | 2.1% | [2.1%, 2.1%] | 1 |
| Regressions ❌ (secondary) | 5.0% | [2.6%, 8.8%] | 5 |
| Improvements ✅ (primary) | -2.9% | [-3.4%, -2.5%] | 2 |
| Improvements ✅ (secondary) | -5.4% | [-8.9%, -1.7%] | 8 |
| All ❌✅ (primary) | -1.3% | [-3.4%, 2.1%] | 3 |
Binary size
Results (primary 1.0%, secondary 0.8%)
A less reliable metric. May be of interest, but not used to determine the overall result above.
| mean | range | count | |
|---|---|---|---|
| Regressions ❌ (primary) | 1.1% | [0.0%, 7.6%] | 48 |
| Regressions ❌ (secondary) | 1.1% | [0.0%, 7.6%] | 15 |
| Improvements ✅ (primary) | -0.1% | [-0.1%, -0.0%] | 5 |
| Improvements ✅ (secondary) | -1.1% | [-2.1%, -0.0%] | 2 |
| All ❌✅ (primary) | 1.0% | [-0.1%, 7.6%] | 53 |
Bootstrap: 475.57s -> 475.799s (0.05%)
Artifact size: 390.76 MiB -> 391.12 MiB (0.09%)