rustdoc: improve the summary icon by liigo · Pull Request #137584 · rust-lang/rust (original) (raw)

I guess this icon should be changed to have two arrows pointing at each other?

If I try to take a survey of similar applications, there's not a very strong consensus here:

• IntelliJ and Notepad++ have expand/collapse all buttons in their directory sidebars that look like this:
  
  This is the only icon design I found that's used by more than one app.
• VSCode has a collapse button in its sidebar that looks like this:
  
• The sidebars in Sublime Text, GitHub's file viewer, ExDoc, MDN, MSDN, and Windows Explorer don't seem to have an options to collapse everything at once at all.
• The "List" view in macOS Finder, the tree comments on Reddit, HN, and Lobsters, and the GitHub Actions log viewer don't have any ways to collapse/expand everything at once, either.
• As for code folding, none of them have a toolbar button. This is the one that truly surprises me, because the option to collapse everything seems most useful if everything is expanded by default (which code viewers do).
  When I customize the toolbar in intellij to add folding buttons to it, they're meaningless placeholders (which still provides no hint for an icon that users might already be familiar with).
  
  Most of them have an option to fold/unfold everything in the command pallet or the menu bar. But Rustdoc doesn't have or want one of those.

Also, a tidy nit

This definitely needs fixed

tidy error: /checkout/src/librustdoc/html/static/css/rustdoc.css:2069: line longer than 100 chars