rust (original) (raw)

Thanks for the PR! Always glad to see test cleanup/improvement efforts.

I left a lot of feedback on individual test changes since you were looking for feedback (to maybe guide your future test changes), and some of them are way more nitpicky than I may fixate on normally.

I reviewed your changes commit-by-commit, so my review comments are best viewed commit-by-commit too.

I'll also point out a commit history nit here: to make it easier during review, I would structure the commits like:

Commit 1 renames test X (maybe move directory and/or rename).
Commit 2 fixes/documents test X.

Notably, I would rebase and fixup test stdout/stderr reblesses to the second "fixes/documents" commit. Then when we decide together after iterations that the test changes look good, I'll ask you to adjust the commit history to have 1 commit per individual test (this is to help future git archaeology).

BTW, you can also add in your PR descriptions that your PR is "Part of #133895" efforts 😁