Add methods to TCP and UDP sockets to modify hop limit (refresh of #94678) by Mallets · Pull Request #138744 · rust-lang/rust (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

r? @ibraheemdev

rustbot has assigned @ibraheemdev.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

rustbot added O-windows

Operating system: Windows

S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

T-libs

Relevant to the library team, which will review and decide on the PR/issue.

labels

Mar 20, 2025

r? libs-api because it's been a while since the original PR was approved.

rustbot added the T-libs-api

Relevant to the library API team, which will review and decide on the PR/issue.

label

Mar 28, 2025

rustbot added S-waiting-on-author

Status: This is awaiting some action (such as code changes or more information) from the author.

and removed S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

Mar 30, 2025

This comment has been minimized.

Co-authored-by: David Tolnay dtolnay@gmail.com

Sorry—I missed that this was ready for review again. Please use @rustbot ready, which replaces S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label with S-waiting-on-review Status: Awaiting review from the assignee but also interested parties..

rustbot added S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

and removed S-waiting-on-author

Status: This is awaiting some action (such as code changes or more information) from the author.

labels

Apr 13, 2025

📌 Commit 25fb525 has been approved by dtolnay

It is now in the queue for this repository.

bors added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

Apr 13, 2025

ChrisDenton added a commit to ChrisDenton/rust that referenced this pull request

Apr 13, 2025

…=dtolnay

Add methods to TCP and UDP sockets to modify hop limit (refresh of rust-lang#94678)

rust-lang#94678 was closed because of time constraints of the original author (@kckeiks).

This PR is a refresh of rust-lang#94678 where the original proposed changes are ported to the current status of the standard library.

In addition, this PR:

implements the change suggested in rust-lang#94678 (comment)
defines set_multicast_hop_limit_v6 and multicast_hop_limit_v6 only for UDP sockets and not for TCP sockets as originally proposed

Issue: rust-lang#139166

ChrisDenton added a commit to ChrisDenton/rust that referenced this pull request

Apr 13, 2025

…=dtolnay

Add methods to TCP and UDP sockets to modify hop limit (refresh of rust-lang#94678)

rust-lang#94678 was closed because of time constraints of the original author (@kckeiks).

This PR is a refresh of rust-lang#94678 where the original proposed changes are ported to the current status of the standard library.

In addition, this PR:

implements the change suggested in rust-lang#94678 (comment)
defines set_multicast_hop_limit_v6 and multicast_hop_limit_v6 only for UDP sockets and not for TCP sockets as originally proposed

Issue: rust-lang#139166

bors added a commit to rust-lang-ci/rust that referenced this pull request

Apr 13, 2025