Simplify expansion for format_args!(). by m-ou-se · Pull Request #139131 · rust-lang/rust (original) (raw)
Finished benchmarking commit (2ea33b5): comparison URL.
Overall result: ❌✅ regressions and improvements - please read the text below
Our benchmarks found a performance regression caused by this PR.
This might be an actual regression, but it can also be just noise.
Next Steps:
- If the regression was expected or you think it can be justified,
please write a comment with sufficient written justification, and add@rustbot label: +perf-regression-triagedto it, to mark the regression as triaged. - If you think that you know of a way to resolve the regression, try to create
a new PR with a fix for the regression. - If you do not understand the regression or you think that it is just noise,
you can ask the@rust-lang/wg-compiler-performanceworking group for help (members of this group
were already notified of this PR).
@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance
Instruction count
This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.
| mean | range | count | |
|---|---|---|---|
| Regressions ❌ (primary) | - | - | 0 |
| Regressions ❌ (secondary) | 0.2% | [0.2%, 0.2%] | 1 |
| Improvements ✅ (primary) | -0.5% | [-0.8%, -0.2%] | 8 |
| Improvements ✅ (secondary) | -0.1% | [-0.1%, -0.1%] | 1 |
| All ❌✅ (primary) | -0.5% | [-0.8%, -0.2%] | 8 |
Max RSS (memory usage)
Results (primary -2.5%, secondary -2.7%)
This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
| mean | range | count | |
|---|---|---|---|
| Regressions ❌ (primary) | 2.1% | [2.1%, 2.1%] | 1 |
| Regressions ❌ (secondary) | - | - | 0 |
| Improvements ✅ (primary) | -4.7% | [-6.2%, -3.2%] | 2 |
| Improvements ✅ (secondary) | -2.7% | [-2.7%, -2.7%] | 1 |
| All ❌✅ (primary) | -2.5% | [-6.2%, 2.1%] | 3 |
Cycles
Results (secondary 3.3%)
This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
| mean | range | count | |
|---|---|---|---|
| Regressions ❌ (primary) | - | - | 0 |
| Regressions ❌ (secondary) | 3.3% | [2.9%, 3.7%] | 6 |
| Improvements ✅ (primary) | - | - | 0 |
| Improvements ✅ (secondary) | - | - | 0 |
| All ❌✅ (primary) | - | - | 0 |
Binary size
Results (primary -0.0%, secondary -0.1%)
This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
| mean | range | count | |
|---|---|---|---|
| Regressions ❌ (primary) | 0.1% | [0.0%, 0.3%] | 16 |
| Regressions ❌ (secondary) | - | - | 0 |
| Improvements ✅ (primary) | -0.1% | [-0.2%, -0.0%] | 33 |
| Improvements ✅ (secondary) | -0.1% | [-0.1%, -0.1%] | 35 |
| All ❌✅ (primary) | -0.0% | [-0.2%, 0.3%] | 49 |
Bootstrap: 776.216s -> 776.873s (0.08%)
Artifact size: 365.95 MiB -> 365.88 MiB (-0.02%)