reference dirfd implementation by Qelxiros · Pull Request #139514 · rust-lang/rust (original) (raw)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I started going through this again, but have a request: would you be open to splitting this PR up some? There is a ton of surface area and it touches all platforms, it's a bit difficult to give everything the attention it needs.

Specifically, this could be split to PRs like:

1. Bare minimum to get things started, Dir::new and Dir:open, From<OwnedFd>, Into<OwnedFd>, AsFd, and AsRawFd, Debug (note, new should probably be called open_dir since it's not creating anything new. Also matches cap-std)
2. Ops for files (open_with, remove_file, etc)
3. Ops for directories (new_with/open_dir_with, remove_dir, etc)
4. Misc things like Dir::symlink and DirEntry API

Feel free to request me for review of the initial since I have looked at that

View changes since this review