[compiletest] Parallelize test discovery by tmandry · Pull Request #140177 · rust-lang/rust (original) (raw)
Member
jieyouxu left a comment • Loading
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! This is quite a significant improvement even in my local testing. It turns out
Certain filesystems
can even include ReFS on a local Windows dev drive.
Test collection time diff
Measured against 1a5bf12 + naive time recording around top-level collect_tests_from_dir
.
x86_64-unknown-linux-gnu
(WSL)
State | collect_tests_from_dir duration on tests/ui |
---|---|
Without this PR | 362.296834ms |
With this PR | 248.394981ms |
x86_64-pc-windows-msvc
(PowerShell, native)
State | collect_tests_from_dir duration on tests/ui |
---|---|
Without this PR | 2.5187741s |
With this PR | 507.9907ms |
Additionally, I ran ./x test ui
and ./x test run-make
to double-check if the number of runned tests and test outcomes look "expected", which they did.