Improve hir pretty printing by nnethercote · Pull Request #140606 · rust-lang/rust (original) (raw)

Sorry for the breakage. Why are there no cargo semver-checks to catch this?

It was caught by the test suites of cargo-semver-checks and its components. Their test suites are fairly extensive (a decent bit larger than the rustdoc JSON tests) and at one point there was discussion about running them in rustdoc's own CI to catch rustdoc JSON bugs (#110815). At the time that seemed like a lot of work for not much gain, but perhaps it's an idea to revisit.

I opened #140689 to track recovering the original behavior, unless we decide to roll forward instead and just bump the format version number. That would be a bit inconvenient, but I can deal with it if it's preferable.