implement PanicTracker to track t panics by onur-ozkan · Pull Request #140636 · rust-lang/rust (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

onur-ozkan

Trying to understand panics triggered by t macro is very exhausting (especially on CI failures) because it doesn't provide any information about where the macro was originally invoked. This change adds that missing information when an inner call inside the t macro panics.

Resolves #137557

@rustbot

r? @Kobzol

rustbot has assigned @Kobzol.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

T-bootstrap

Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

labels

May 4, 2025

@onur-ozkan

Trying to understand panics triggered by t macro calls is very exhausting (especially on CI failures) because it doesn't provide any information about where the macro was originally invoked. This change adds that missing information when an inner call inside the t macro panics.

Signed-off-by: onur-ozkan work@onurozkan.dev

@Loweredgames

This comment has been minimized.

@bors

This comment has been minimized.

@bors

This comment has been minimized.

@Loweredgames

This comment has been minimized.

@Kobzol

Nice one.

@bors r+ rollup

@bors

📌 Commit de44231 has been approved by Kobzol

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

May 5, 2025

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request

May 5, 2025

@GuillaumeGomez

…ro, r=Kobzol

implement PanicTracker to track t panics

Trying to understand panics triggered by t macro is very exhausting (especially on CI failures) because it doesn't provide any information about where the macro was originally invoked. This change adds that missing information when an inner call inside the t macro panics.

Resolves rust-lang#137557

Labels

S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

T-bootstrap

Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)