Rollup of 4 pull requests by tgross35 · Pull Request #140650 · rust-lang/rust (original) (raw)
Finished benchmarking commit (54d024e): comparison URL.
Overall result: ❌✅ regressions and improvements - please read the text below
Our benchmarks found a performance regression caused by this PR.
This might be an actual regression, but it can also be just noise.
Next Steps:
- If the regression was expected or you think it can be justified,
please write a comment with sufficient written justification, and add@rustbot label: +perf-regression-triagedto it, to mark the regression as triaged. - If you think that you know of a way to resolve the regression, try to create
a new PR with a fix for the regression. - If you do not understand the regression or you think that it is just noise,
you can ask the@rust-lang/wg-compiler-performanceworking group for help (members of this group
were already notified of this PR).
@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance
Instruction count
This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.
| mean | range | count | |
|---|---|---|---|
| Regressions ❌ (primary) | 0.7% | [0.7%, 0.7%] | 1 |
| Regressions ❌ (secondary) | - | - | 0 |
| Improvements ✅ (primary) | -0.3% | [-0.3%, -0.3%] | 2 |
| Improvements ✅ (secondary) | - | - | 0 |
| All ❌✅ (primary) | 0.0% | [-0.3%, 0.7%] | 3 |
Max RSS (memory usage)
Results (primary -0.6%, secondary -2.5%)
This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
| mean | range | count | |
|---|---|---|---|
| Regressions ❌ (primary) | 1.6% | [0.5%, 5.6%] | 5 |
| Regressions ❌ (secondary) | - | - | 0 |
| Improvements ✅ (primary) | -1.3% | [-6.0%, -0.4%] | 17 |
| Improvements ✅ (secondary) | -2.5% | [-2.5%, -2.5%] | 1 |
| All ❌✅ (primary) | -0.6% | [-6.0%, 5.6%] | 22 |
Cycles
Results (primary -0.1%, secondary 8.1%)
This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
| mean | range | count | |
|---|---|---|---|
| Regressions ❌ (primary) | 0.6% | [0.4%, 0.8%] | 5 |
| Regressions ❌ (secondary) | 8.1% | [1.9%, 10.7%] | 4 |
| Improvements ✅ (primary) | -0.5% | [-0.6%, -0.4%] | 8 |
| Improvements ✅ (secondary) | - | - | 0 |
| All ❌✅ (primary) | -0.1% | [-0.6%, 0.8%] | 13 |
Binary size
Results (primary 0.0%)
This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
| mean | range | count | |
|---|---|---|---|
| Regressions ❌ (primary) | 0.1% | [0.0%, 0.2%] | 11 |
| Regressions ❌ (secondary) | - | - | 0 |
| Improvements ✅ (primary) | -0.2% | [-0.2%, -0.1%] | 4 |
| Improvements ✅ (secondary) | - | - | 0 |
| All ❌✅ (primary) | 0.0% | [-0.2%, 0.2%] | 15 |
Bootstrap: 769.045s -> 769.467s (0.05%)
Artifact size: 365.44 MiB -> 365.38 MiB (-0.02%)